Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust estimate_num_groups calls to PG14 changes #3524

Merged
merged 3 commits into from Aug 31, 2021

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Aug 26, 2021

PG14 adds an additional argument to estimate_num_groups to
allow passing back additional information about the estimation.

postgres/postgres@ed934d4fa3

Disable-check: commit-count

@svenklemm svenklemm requested a review from a team as a code owner August 26, 2021 02:29
@svenklemm svenklemm requested review from erimatnor, mkindahl and nikkhils and removed request for a team August 26, 2021 02:29
@svenklemm svenklemm self-assigned this Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #3524 (14aa77d) into master (a8a9941) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 14aa77d differs from pull request most recent head 5dad60a. Consider uploading reports for the commit 5dad60a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3524      +/-   ##
==========================================
- Coverage   90.69%   90.69%   -0.01%     
==========================================
  Files         212      212              
  Lines       36278    36277       -1     
==========================================
- Hits        32903    32901       -2     
- Misses       3375     3376       +1     
Impacted Files Coverage Δ
src/compat/compat.h 100.00% <ø> (ø)
src/estimate.c 88.11% <100.00%> (ø)
tsl/src/fdw/estimate.c 97.22% <100.00%> (-0.04%) ⬇️
tsl/src/nodes/data_node_dispatch.c 97.08% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a9941...5dad60a. Read the comment docs.

PG14 adds an additional argument to estimate_num_groups to
allow passing back additional information about the estimation.

postgres/postgres@ed934d4fa3
The list_make5 macros got removed in PG13 but PG14 adds them back.

postgres/postgres@b663a41
Running the RPM package test workflow was accidently left on for PR
from testing when adding the downgrade test for RPM packages.
@svenklemm svenklemm merged commit 76ad386 into timescale:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants