Remove pointers from CAGG lists for 64-bit archs #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfundul
force-pushed
the
fix-64bit-list
branch
from
c3949a5
to
ae2fc7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3824 +/- ##
========================================
Coverage 90.56% 90.57%
========================================
Files 213 213
Lines 37771 37881 +110
========================================
+ Hits 34209 34312 +103
- Misses 3562 3569 +7
Continue to review full report at Codecov.
|
akuzm
approved these changes
Nov 18, 2021
mkindahl
reviewed
Nov 18, 2021
Currently, the int64 elements are always passed by reference, which is not necessary on 64-bit architectures where it can be passed by value. Make it so they are only passed by reference for 32-bit architectures and by value for 64-bit architectures, since the element fits in a 64-bit architecture pointer.
mfundul
force-pushed
the
fix-64bit-list
branch
from
ae2fc7d
to
d5fef96
Compare
mkindahl
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the int64 elements are always passed by reference, which is
not necessary on 64-bit architectures where it can be passed by value.
Make it so they are only passed by reference for 32-bit architectures
and by value for 64-bit architectures, since the element fits in a
64-bit architecture pointer.
Fixes #3816