New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enhancement issue template #3832
Add enhancement issue template #3832
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3832 +/- ##
==========================================
- Coverage 90.59% 90.59% -0.01%
==========================================
Files 213 213
Lines 37905 37904 -1
==========================================
- Hits 34340 34339 -1
Misses 3565 3565
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tech-debt (with label).
4690324
to
d7d411b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It would probably be good to go over the labels to make sure that we have consistent names between labels and options in this list.
- Continuous aggregate | ||
- Background worker | ||
- Policy | ||
- User-Defined Action (UDA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label is currently custom-action
so we should probably change the name of that one if we use this labeloption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that these aren't translated into labels so there is no 1-1 match right now. Also, if we add a job to turn these into labels, we need not have exactly matching names anyway.
I think priority here is to be user descriptive, rather than matching labels since users will add these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, noted that, but it is good for our own usage that the match between the options and the labels are similar. For example, "User Defined Actions" and "Custom Actions" are quite different and it will be confusing if we do not try to keep them similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change labels at any time and it does not affect this part of the PR. Again, the thing in this list is not a label and User-defined Action is the official term that we also use in docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So change the name of the label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but what does it have to do with this PR? Especially since this is not a list of labels? We don't have labels for many things on this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has nothing to do with this PR? I already approved it and you can push it, but I just added that you might want to change the labels to match the options to avoid confusion when triaging?
6ec3752
to
9595598
Compare
Add an issue template for "Enhancement" requests. An enhancement is an improvement to an existing feature or functionality. The user must pick from a set of features or subsystems to improve.
9595598
to
61692c4
Compare
Add an issue template for "Enhancement" requests. An enhancement is an
improvement to an existing feature or functionality. The user must
pick from a set of features or subsystems to improve.