Fix subtract_integer_from_now on 32-bit platforms and improve error handling #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
berkley,
pmwkaa,
RafiaSabih,
gayyappan,
afiskon,
akuzm,
erimatnor,
fabriziomello,
mfundul and
nikkhils
and removed request for
a team
fabriziomello
approved these changes
Dec 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #3938 +/- ##
==========================================
- Coverage 90.72% 90.72% -0.01%
==========================================
Files 213 213
Lines 38445 38458 +13
==========================================
+ Hits 34881 34892 +11
- Misses 3564 3566 +2
Continue to review full report at Codecov.
|
pmwkaa
approved these changes
Dec 17, 2021
svenklemm
force-pushed
the
subtract_integer_from_now
branch
8 times, most recently
from
e53adb8
to
ad2e723
Compare
svenklemm
changed the title
svenklemm
changed the title
svenklemm
force-pushed
the
subtract_integer_from_now
branch
from
2af9e6a
to
269da08
Compare
This patch fixes subtract_integer_from_now on 32-bit platforms, improves error handling and adds some basic tests. subtract_integer_from_now would trigger an assert when called on a hypertable without integer time dimension (found by sqlsmith). Additionally subtract_integer_from_now would segfault when called on a hypertable without partitioning dimensions.
This patch fixes a segfault when calling show_chunks on internal compressed hypertable and a cache lookup failure for drop_chunks when calling on internal compressed hypertable.
When trying to create a continuous aggregate on the internal compression hypertable a segfault would occur. This patch adds a check for this to the cagg validation logic and prevents creating cagg on the internal compressed hypertable.
svenklemm
force-pushed
the
subtract_integer_from_now
branch
from
269da08
to
bfe5b1d
Compare
When trying to add reorder policy to internal compressed hypertable add_reorder_policy would segfault.
svenklemm
force-pushed
the
subtract_integer_from_now
branch
from
bfe5b1d
to
169038b
Compare
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 8, 2022
This release contains bug fixes since the 2.5.1 release. We deem it high priority to upgrade. **Bugfixes** * timescale#3918 Fix DataNodeScan plans with one-time filter * timescale#3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * timescale#3939 Fix projection handling in time_bucket_gapfill * timescale#3979 Fix deparsing of index predicates * timescale#4020 Fix ALTER TABLE EventTrigger initialization * timescale#4024 Fix premature cache release call **Thanks** * @erikhh for reporting an issue with time_bucket_gapfill * @kancsuki for reporting drop column and partial index creation not working
Merged
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 8, 2022
This release contains bug fixes since the 2.5.1 release. We deem it high priority to upgrade. **Bugfixes** * timescale#3918 Fix DataNodeScan plans with one-time filter * timescale#3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * timescale#3939 Fix projection handling in time_bucket_gapfill * timescale#3979 Fix deparsing of index predicates * timescale#4020 Fix ALTER TABLE EventTrigger initialization * timescale#4024 Fix premature cache release call **Thanks** * @erikhh for reporting an issue with time_bucket_gapfill * @kancsuki for reporting drop column and partial index creation not working
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 8, 2022
This release contains bug fixes since the 2.5.1 release. We deem it high priority to upgrade. **Bugfixes** * timescale#3918 Fix DataNodeScan plans with one-time filter * timescale#3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * timescale#3939 Fix projection handling in time_bucket_gapfill * timescale#3979 Fix deparsing of index predicates * timescale#4020 Fix ALTER TABLE EventTrigger initialization * timescale#4024 Fix premature cache release call **Thanks** * @erikhh for reporting an issue with time_bucket_gapfill * @kancsuki for reporting drop column and partial index creation not working
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 8, 2022
This release contains bug fixes since the 2.5.1 release. We deem it high priority to upgrade. **Bugfixes** * timescale#3918 Fix DataNodeScan plans with one-time filter * timescale#3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * timescale#3939 Fix projection handling in time_bucket_gapfill * timescale#3979 Fix deparsing of index predicates * timescale#4020 Fix ALTER TABLE EventTrigger initialization * timescale#4024 Fix premature cache release call **Thanks** * @erikhh for reporting an issue with time_bucket_gapfill * @kancsuki for reporting drop column and partial index creation not working
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 8, 2022
This release contains bug fixes since the 2.5.1 release. We deem it high priority to upgrade. **Bugfixes** * timescale#3918 Fix DataNodeScan plans with one-time filter * timescale#3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * timescale#3939 Fix projection handling in time_bucket_gapfill * timescale#3979 Fix deparsing of index predicates * timescale#4020 Fix ALTER TABLE EventTrigger initialization * timescale#4024 Fix premature cache release call **Thanks** * @erikhh for reporting an issue with time_bucket_gapfill * @kancsuki for reporting drop column and partial index creation not working
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. We deem it high priority to upgrade. **Bugfixes** * timescale#3901 Improve custom scan node registration * timescale#3911 Fix role type deparsing for GRANT command * timescale#3918 Fix DataNodeScan plans with one-time filter * timescale#3921 Fix segfault on insert into internal compressed table * timescale#3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * timescale#3939 Fix projection handling in time_bucket_gapfill * timescale#3948 Avoid double PGclear() in data fetchers * timescale#3979 Fix deparsing of index predicates * timescale#4020 Fix ALTER TABLE EventTrigger initialization * timescale#4024 Fix premature cache release call * timescale#4037 Fix status for dropped chunks that have catalog entries * timescale#4069 Fix riinfo NULL handling in ANY construct * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. We deem it high priority to upgrade. **Bugfixes** * timescale#3901 Improve custom scan node registration * timescale#3911 Fix role type deparsing for GRANT command * timescale#3918 Fix DataNodeScan plans with one-time filter * timescale#3921 Fix segfault on insert into internal compressed table * timescale#3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * timescale#3939 Fix projection handling in time_bucket_gapfill * timescale#3948 Avoid double PGclear() in data fetchers * timescale#3979 Fix deparsing of index predicates * timescale#4020 Fix ALTER TABLE EventTrigger initialization * timescale#4024 Fix premature cache release call * timescale#4037 Fix status for dropped chunks that have catalog entries * timescale#4069 Fix riinfo NULL handling in ANY construct **Thanks** * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate * Pedro Gallegos for reporting a possible privilege escalation during extension installation Security: CVE-2022-24128
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * timescale#3901 Improve custom scan node registration * timescale#3911 Fix role type deparsing for GRANT command * timescale#3918 Fix DataNodeScan plans with one-time filter * timescale#3921 Fix segfault on insert into internal compressed table * timescale#3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * timescale#3939 Fix projection handling in time_bucket_gapfill * timescale#3948 Avoid double PGclear() in data fetchers * timescale#3979 Fix deparsing of index predicates * timescale#4020 Fix ALTER TABLE EventTrigger initialization * timescale#4024 Fix premature cache release call * timescale#4037 Fix status for dropped chunks that have catalog entries * timescale#4069 Fix riinfo NULL handling in ANY construct * timescale#4071 Fix extension installation privilege escalation **Thanks** * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate * Pedro Gallegos for reporting a possible privilege escalation during extension installation Security: CVE-2022-24128
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * timescale#3900 Improve custom scan node registration * timescale#3911 Fix role type deparsing for GRANT command * timescale#3918 Fix DataNodeScan plans with one-time filter * timescale#3921 Fix segfault on insert into internal compressed table * timescale#3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * timescale#3939 Fix projection handling in time_bucket_gapfill * timescale#3948 Avoid double PGclear() in data fetchers * timescale#3979 Fix deparsing of index predicates * timescale#4015 Eliminate float rounding instabilities in interpolate * timescale#4020 Fix ALTER TABLE EventTrigger initialization * timescale#4024 Fix premature cache release call * timescale#4037 Fix status for dropped chunks that have catalog entries * timescale#4069 Fix riinfo NULL handling in ANY construct * timescale#4071 Fix extension installation privilege escalation * timescale#4073 Fix buffer overflow in partition scheme **Thanks** * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @fvannee for reporting a first/last memory leak * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate * Pedro Gallegos for reporting a possible privilege escalation during extension installation Security: CVE-2022-24128
svenklemm
added a commit
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #3900 Improve custom scan node registration * #3911 Fix role type deparsing for GRANT command * #3918 Fix DataNodeScan plans with one-time filter * #3921 Fix segfault on insert into internal compressed table * #3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * #3939 Fix projection handling in time_bucket_gapfill * #3948 Avoid double PGclear() in data fetchers * #3979 Fix deparsing of index predicates * #4015 Eliminate float rounding instabilities in interpolate * #4020 Fix ALTER TABLE EventTrigger initialization * #4024 Fix premature cache release call * #4037 Fix status for dropped chunks that have catalog entries * #4069 Fix riinfo NULL handling in ANY construct * #4071 Fix extension installation privilege escalation * #4073 Fix buffer overflow in partition scheme **Thanks** * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @fvannee for reporting a first/last memory leak * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate * Pedro Gallegos for reporting a possible privilege escalation during extension installation Security: CVE-2022-24128
svenklemm
added a commit
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #3900 Improve custom scan node registration * #3911 Fix role type deparsing for GRANT command * #3918 Fix DataNodeScan plans with one-time filter * #3921 Fix segfault on insert into internal compressed table * #3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * #3939 Fix projection handling in time_bucket_gapfill * #3948 Avoid double PGclear() in data fetchers * #3979 Fix deparsing of index predicates * #4015 Eliminate float rounding instabilities in interpolate * #4020 Fix ALTER TABLE EventTrigger initialization * #4024 Fix premature cache release call * #4037 Fix status for dropped chunks that have catalog entries * #4069 Fix riinfo NULL handling in ANY construct * #4071 Fix extension installation privilege escalation * #4073 Fix buffer overflow in partition scheme **Thanks** * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @fvannee for reporting a first/last memory leak * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate * Pedro Gallegos for reporting a possible privilege escalation during extension installation Security: CVE-2022-24128
svenklemm
added a commit
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #3900 Improve custom scan node registration * #3911 Fix role type deparsing for GRANT command * #3918 Fix DataNodeScan plans with one-time filter * #3921 Fix segfault on insert into internal compressed table * #3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * #3939 Fix projection handling in time_bucket_gapfill * #3948 Avoid double PGclear() in data fetchers * #3979 Fix deparsing of index predicates * #4015 Eliminate float rounding instabilities in interpolate * #4020 Fix ALTER TABLE EventTrigger initialization * #4024 Fix premature cache release call * #4037 Fix status for dropped chunks that have catalog entries * #4069 Fix riinfo NULL handling in ANY construct * #4071 Fix extension installation privilege escalation * #4073 Fix buffer overflow in partition scheme **Thanks** * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @fvannee for reporting a first/last memory leak * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate * Pedro Gallegos for reporting a possible privilege escalation during extension installation Security: CVE-2022-24128
svenklemm
added a commit
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #3900 Improve custom scan node registration * #3911 Fix role type deparsing for GRANT command * #3918 Fix DataNodeScan plans with one-time filter * #3921 Fix segfault on insert into internal compressed table * #3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * #3939 Fix projection handling in time_bucket_gapfill * #3948 Avoid double PGclear() in data fetchers * #3979 Fix deparsing of index predicates * #4015 Eliminate float rounding instabilities in interpolate * #4020 Fix ALTER TABLE EventTrigger initialization * #4024 Fix premature cache release call * #4037 Fix status for dropped chunks that have catalog entries * #4069 Fix riinfo NULL handling in ANY construct * #4071 Fix extension installation privilege escalation * #4073 Fix buffer overflow in partition scheme **Thanks** * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @fvannee for reporting a first/last memory leak * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate * Pedro Gallegos for reporting a possible privilege escalation during extension installation Security: CVE-2022-24128
svenklemm
added a commit
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #3900 Improve custom scan node registration * #3911 Fix role type deparsing for GRANT command * #3918 Fix DataNodeScan plans with one-time filter * #3921 Fix segfault on insert into internal compressed table * #3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * #3939 Fix projection handling in time_bucket_gapfill * #3948 Avoid double PGclear() in data fetchers * #3979 Fix deparsing of index predicates * #4015 Eliminate float rounding instabilities in interpolate * #4020 Fix ALTER TABLE EventTrigger initialization * #4024 Fix premature cache release call * #4037 Fix status for dropped chunks that have catalog entries * #4069 Fix riinfo NULL handling in ANY construct * #4071 Fix extension installation privilege escalation **Thanks** * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @fvannee for reporting a first/last memory leak * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate * Pedro Gallegos for reporting a possible privilege escalation during extension installation Security: CVE-2022-24128
svenklemm
added a commit
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #3900 Improve custom scan node registration * #3911 Fix role type deparsing for GRANT command * #3918 Fix DataNodeScan plans with one-time filter * #3921 Fix segfault on insert into internal compressed table * #3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * #3939 Fix projection handling in time_bucket_gapfill * #3948 Avoid double PGclear() in data fetchers * #3979 Fix deparsing of index predicates * #4015 Eliminate float rounding instabilities in interpolate * #4020 Fix ALTER TABLE EventTrigger initialization * #4024 Fix premature cache release call * #4037 Fix status for dropped chunks that have catalog entries * #4069 Fix riinfo NULL handling in ANY construct * #4071 Fix extension installation privilege escalation **Thanks** * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @fvannee for reporting a first/last memory leak * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate * Pedro Gallegos for reporting a possible privilege escalation during extension installation Security: CVE-2022-24128
svenklemm
added a commit
that referenced
this pull request
Feb 9, 2022
This release contains bug fixes since the 2.5.1 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #3900 Improve custom scan node registration * #3911 Fix role type deparsing for GRANT command * #3918 Fix DataNodeScan plans with one-time filter * #3921 Fix segfault on insert into internal compressed table * #3938 Fix subtract_integer_from_now on 32-bit platforms and improve error handling * #3939 Fix projection handling in time_bucket_gapfill * #3948 Avoid double PGclear() in data fetchers * #3979 Fix deparsing of index predicates * #4015 Eliminate float rounding instabilities in interpolate * #4020 Fix ALTER TABLE EventTrigger initialization * #4024 Fix premature cache release call * #4037 Fix status for dropped chunks that have catalog entries * #4069 Fix riinfo NULL handling in ANY construct * #4071 Fix extension installation privilege escalation **Thanks** * @carlocperez for reporting crash with NULL handling in ANY construct * @erikhh for reporting an issue with time_bucket_gapfill * @fvannee for reporting a first/last memory leak * @kancsuki for reporting drop column and partial index creation not working * @mmouterde for reporting an issue with floats and interpolate * Pedro Gallegos for reporting a possible privilege escalation during extension installation Security: CVE-2022-24128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would trigger an assert when called on a hypertable without
integer time dimension. Found by sqlsmith.
Disable-check: commit-count