Fix shellcheck warnings #4042
Merged
Fix shellcheck warnings #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiskon
approved these changes
Feb 1, 2022
akuzm
reviewed
Feb 1, 2022
scripts/test_downgrade_from_tag.sh
Outdated
| @@ -158,7 +158,8 @@ wait_for_pg() { | |||
| exit 1 | |||
| } | |||
|
|
|||
| VERSION=`echo ${UPDATE_FROM_TAG} | sed 's/\([0-9]\{0,\}\.[0-9]\{0,\}\.[0-9]\{0,\}\).*/\1/g'` | |||
| # shellcheck disable=SC2001 | |||
There was a problem hiding this comment.
Suggested change
| # shellcheck disable=SC2001 | |
| # shellcheck disable=SC2001 -- See if you can use ${variable//search/replace} instead. |
I find it convenient to add the description of what is disabled. Not sure it works in this syntax though, maybe a new line is required.
There was a problem hiding this comment.
Judging from their docs, should work with a second # instead of dashes
Suggested change
| # shellcheck disable=SC2001 | |
| # shellcheck disable=SC2001 # See if you can use ${variable//search/replace} instead. |
akuzm
reviewed
Feb 1, 2022
scripts/test_downgrade_from_tag.sh
Outdated
Comment on lines
141
to
142
| # shellcheck disable=SC2034 | ||
| for i in {1..20}; do |
There was a problem hiding this comment.
Suggested change
| # shellcheck disable=SC2034 | |
| for i in {1..20}; do | |
| for _ in {1..20}; do |
We can use underscore for dummy variables, shellcheck won't complain.
akuzm
approved these changes
Feb 1, 2022
mfundul
force-pushed
the
fix-shellcheck
branch
2 times, most recently
from
4129165
to
1eaf2c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4042 +/- ##
==========================================
- Coverage 90.70% 90.66% -0.04%
==========================================
Files 214 214
Lines 38726 38733 +7
==========================================
- Hits 35126 35118 -8
- Misses 3600 3615 +15
Continue to review full report at Codecov.
|
mkindahl
approved these changes
Feb 1, 2022
scripts/test_downgrade_from_tag.sh
Outdated
| @@ -194,7 +194,7 @@ docker_pgcmd ${CONTAINER_ORIG} "CHECKPOINT;" | |||
| srcdir=$(docker exec ${CONTAINER_ORIG} /bin/bash -c 'pg_config --pkglibdir') | |||
| FILES=$(docker exec ${CONTAINER_ORIG} /bin/bash -c "ls $srcdir/timescaledb*.so") | |||
| for file in $FILES; do | |||
| docker cp ${CONTAINER_ORIG}:$file ${TEST_TMPDIR}/`basename $file` | |||
| docker cp ${CONTAINER_ORIG}:$file "${TEST_TMPDIR}/$(basename $file)" | |||
There was a problem hiding this comment.
Do you need quotes around the first parameter too?
There was a problem hiding this comment.
I can add those as well.
scripts/test_downgrade_from_tag.sh
Outdated
| @@ -205,8 +205,8 @@ docker_run_vol ${CONTAINER_UPDATED} ${UPDATE_VOLUME}:/var/lib/postgresql/data ${ | |||
|
|
|||
| dstdir=$(docker exec ${CONTAINER_UPDATED} /bin/bash -c 'pg_config --pkglibdir') | |||
| for file in $FILES; do | |||
| docker cp ${TEST_TMPDIR}/`basename $file` ${CONTAINER_UPDATED}:$dstdir | |||
| rm ${TEST_TMPDIR}/`basename $file` | |||
| docker cp "${TEST_TMPDIR}/$(basename $file)" ${CONTAINER_UPDATED}:$dstdir | |||
There was a problem hiding this comment.
Do you need quotes around the last parameter too?
mfundul
force-pushed
the
fix-shellcheck
branch
from
1eaf2c9
to
ac67368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.