Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force clang-tidy on #4407

Merged
merged 1 commit into from Jun 2, 2022
Merged

Don't force clang-tidy on #4407

merged 1 commit into from Jun 2, 2022

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Jun 1, 2022

If the compiler is gcc, clang-tidy might not recognize some of its
flags and error out. It will be enabled by default if the compiler is
clang.

If the compiler is gcc, clang-tidy might not recognize some of its
flags and error out. It will be enabled by default if the compiler is
clang.
@akuzm akuzm requested a review from a team as a code owner June 1, 2022 12:27
@akuzm akuzm requested review from erimatnor and svenklemm and removed request for a team June 1, 2022 12:27
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #4407 (1663926) into main (533e849) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4407      +/-   ##
==========================================
- Coverage   90.86%   90.83%   -0.04%     
==========================================
  Files         220      220              
  Lines       40498    40497       -1     
==========================================
- Hits        36800    36784      -16     
- Misses       3698     3713      +15     
Impacted Files Coverage Δ
src/bgw/scheduler.c 82.89% <0.00%> (-2.66%) ⬇️
src/loader/bgw_message_queue.c 85.52% <0.00%> (-2.64%) ⬇️
src/bgw/job.c 93.04% <0.00%> (-0.29%) ⬇️
tsl/src/nodes/data_node_dispatch.c 97.10% <0.00%> (-0.25%) ⬇️
tsl/src/bgw_policy/job.c 88.62% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533e849...1663926. Read the comment docs.

@akuzm akuzm merged commit ed948b1 into timescale:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants