New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault when executing IMMUTABLE functions #4493
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4493 +/- ##
==========================================
- Coverage 90.79% 90.77% -0.02%
==========================================
Files 221 222 +1
Lines 41003 41084 +81
==========================================
+ Hits 37228 37296 +68
- Misses 3775 3788 +13
Continue to review full report at Codecov.
|
bfc4542
to
6ef1e67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Executing an IMMUTABLE function that has parameters and exception handling block multiple times in the same transaction causes a null pointer segfault when try to reset a non-initialized ts_baserel_info. Fixed it by preventing to reset a non-initialized `ts_baserel_info`. Fixes timescale#4489
This release is a patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #4494 Handle timescaledb versions aptly in multinode * #4493 Segfault when executing IMMUTABLE functions * #4482 Fix race conditions during chunk (de)compression * #4367 Improved buffer management in the copy operator * #4375 Don't ask for orderby column if default already set * #4400 Use our implementation of `find_em_expr_for_rel` for PG15+ * #4408 Fix crash during insert into distributed hypertable * #4411 Add `shmem_request_hook` * #4437 Fix segfault in subscription_exec * #4442 Fix perms in copy/move chunk * #4450 Retain hypertable ownership on `attach_data_node` * #4451 Repair numeric partial state on the fly * #4463 Fix empty bytea handlng with distributed tables * #4469 Better superuser handling for `move_chunk` **Features** * #4244 Function telemetry * #4287 Add internal api for foreign table chunk * #4470 Block drop chunk if chunk is in frozen state * #4464 Add internal api to associate a hypertable with custom jobs **Thanks** * @xin-hedera Finding bug in empty bytea values for distributed tables * @jflambert for reporting a bug with IMMUTABLE functions * @nikugogoi for reporting a bug with CTEs and upserts on distributed hypertables
This release is a patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #4494 Handle timescaledb versions aptly in multinode * #4493 Segfault when executing IMMUTABLE functions * #4482 Fix race conditions during chunk (de)compression * #4367 Improved buffer management in the copy operator * #4375 Don't ask for orderby column if default already set * #4400 Use our implementation of `find_em_expr_for_rel` for PG15+ * #4408 Fix crash during insert into distributed hypertable * #4411 Add `shmem_request_hook` * #4437 Fix segfault in subscription_exec * #4442 Fix perms in copy/move chunk * #4450 Retain hypertable ownership on `attach_data_node` * #4451 Repair numeric partial state on the fly * #4463 Fix empty bytea handlng with distributed tables * #4469 Better superuser handling for `move_chunk` **Features** * #4244 Function telemetry * #4287 Add internal api for foreign table chunk * #4470 Block drop chunk if chunk is in frozen state * #4464 Add internal api to associate a hypertable with custom jobs **Thanks** * @xin-hedera Finding bug in empty bytea values for distributed tables * @jflambert for reporting a bug with IMMUTABLE functions * @nikugogoi for reporting a bug with CTEs and upserts on distributed hypertables
This release is a patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #4494 Handle timescaledb versions aptly in multinode * #4493 Segfault when executing IMMUTABLE functions * #4482 Fix race conditions during chunk (de)compression * #4367 Improved buffer management in the copy operator * #4375 Don't ask for orderby column if default already set * #4400 Use our implementation of `find_em_expr_for_rel` for PG15+ * #4408 Fix crash during insert into distributed hypertable * #4411 Add `shmem_request_hook` * #4437 Fix segfault in subscription_exec * #4442 Fix perms in copy/move chunk * #4450 Retain hypertable ownership on `attach_data_node` * #4451 Repair numeric partial state on the fly * #4463 Fix empty bytea handlng with distributed tables * #4469 Better superuser handling for `move_chunk` **Features** * #4244 Function telemetry * #4287 Add internal api for foreign table chunk * #4470 Block drop chunk if chunk is in frozen state * #4464 Add internal api to associate a hypertable with custom jobs **Thanks** * @xin-hedera Finding bug in empty bytea values for distributed tables * @jflambert for reporting a bug with IMMUTABLE functions * @nikugogoi for reporting a bug with CTEs and upserts on distributed hypertables
This release is a patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #4494 Handle timescaledb versions aptly in multinode * #4493 Segfault when executing IMMUTABLE functions * #4482 Fix race conditions during chunk (de)compression * #4367 Improved buffer management in the copy operator * #4375 Don't ask for orderby column if default already set * #4400 Use our implementation of `find_em_expr_for_rel` for PG15+ * #4408 Fix crash during insert into distributed hypertable * #4411 Add `shmem_request_hook` * #4437 Fix segfault in subscription_exec * #4442 Fix perms in copy/move chunk * #4450 Retain hypertable ownership on `attach_data_node` * #4451 Repair numeric partial state on the fly * #4463 Fix empty bytea handlng with distributed tables * #4469 Better superuser handling for `move_chunk` **Features** * #4244 Function telemetry * #4287 Add internal api for foreign table chunk * #4470 Block drop chunk if chunk is in frozen state * #4464 Add internal api to associate a hypertable with custom jobs **Thanks** * @xin-hedera Finding bug in empty bytea values for distributed tables * @jflambert for reporting a bug with IMMUTABLE functions * @nikugogoi for reporting a bug with CTEs and upserts on distributed hypertables
Executing an IMMUTABLE function that has parameters and exception
handling block multiple times in the same transaction causes a null
pointer segfault when try to reset a non-initialized
ts_baserel_info
.Fixed it by preventing to reset a non-initialized
ts_baserel_info
.Fixes #4489