Schema-qualify function telemetry #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4643 +/- ##
==========================================
+ Coverage 90.77% 90.78% +0.01%
==========================================
Files 224 224
Lines 41915 41970 +55
==========================================
+ Hits 38047 38103 +56
+ Misses 3868 3867 -1
Continue to review full report at Codecov.
|
svenklemm
approved these changes
Aug 22, 2022
JLockerman
force-pushed
the
jl/schema-schema-qualify-fn-telemetry
branch
from
c8c2103
to
c55b3b3
Compare
This commit unconditionally schema-qualifies the function telemetry. In the default setting `format_procedure()` only schema-qualifies things that aren't on the search path. This could cause to much variation across users. Further, it'd be nice to tell if functions in-use are from an experimental schema or a main one.
JLockerman
force-pushed
the
jl/schema-schema-qualify-fn-telemetry
branch
from
c55b3b3
to
a4aae58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unconditionally schema-qualifies the function telemetry. In the default setting
format_procedure()only schema-qualifies things that aren't on the search path. This could cause to much variation across users. Further, it'd be nice to tell if functions in-use are from an experimental schema or a main one.