Fix const null clauses in runtime chunk exclusion #4880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4880 +/- ##
==========================================
+ Coverage 89.51% 89.62% +0.11%
==========================================
Files 226 226
Lines 50818 51105 +287
==========================================
+ Hits 45491 45805 +314
+ Misses 5327 5300 -27
Continue to review full report at Codecov.
|
|
@akuzm just an advice, you can ask for support folks to convert the SDC issue into a public issue. |
svenklemm
reviewed
Nov 1, 2022
There was one null value in the |
svenklemm
approved these changes
Nov 2, 2022
fabriziomello
approved these changes
Nov 14, 2022
akuzm
force-pushed
the
const-null
branch
5 times, most recently
from
403e777
to
f3a6234
Compare
The code we inherited from postgres expects that if we have a const null or false clause, it's going to be the single one, but that's not true for runtime chunk exclusion because we don't try to fold such restrictinfos after evaluating the mutable functions. Fix it to also work for multiple restrictinfos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code we inherited from postgres expects that if we have a const null or false clause, it's going to be the single one, but that's not true for runtime chunk exclusion because we don't try to fold such restrictinfos after evaluating the mutable functions. Fix it to also work for multiple restrictinfos.
Related to https://github.com/timescale/Support-Dev-Collab/issues/620
Disable-check: commit-count