Add the Flaky Check #4883
Merged
Add the Flaky Check #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4883 +/- ##
==========================================
- Coverage 89.48% 89.44% -0.05%
==========================================
Files 225 225
Lines 50288 50287 -1
==========================================
- Hits 45001 44978 -23
- Misses 5287 5309 +22
Continue to review full report at Codecov.
|
nikkhils
reviewed
Oct 31, 2022
| "installcheck_args": "IGNORES='bgw_db_scheduler bgw_db_scheduler_fixed bgw_launcher pg_dump remote_connection compressed_collation'", | ||
| "llvm_config": "/usr/local/opt/llvm/bin/llvm-config", | ||
| "os": "macos-11", | ||
| "pg": PG12_LATEST, |
There was a problem hiding this comment.
Should we still use PG12 here?
There was a problem hiding this comment.
I don't know... probably should remove support when we start supporting PG 15.
There was a problem hiding this comment.
The plan is remove it when we have full PG15 support!
test/sql/agg_bookends.sql.in
Outdated
| @@ -31,3 +31,5 @@ SET timescaledb.enable_optimizations TO true; | |||
| \o | |||
|
|
|||
| :DIFF_CMD | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Suggested change
Leftover?
There was a problem hiding this comment.
Yep, I used them to test that the check works.
fabriziomello
approved these changes
Oct 31, 2022
It runs new or changed tests multiple times to find flakiness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It runs the changed tests many times to find flakiness.