Refactor Continuous Aggregate catalog code #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
added
continuous_aggregate
tech-debt
fabriziomello
force-pushed
the
refactor_continuous_agg_catalog_code
branch
from
3cd98fe
to
33763f1
Compare
akuzm
approved these changes
Oct 27, 2022
fabriziomello
force-pushed
the
refactor_continuous_agg_catalog_code
branch
from
33763f1
to
b9d4825
Compare
Codecov Report
@@ Coverage Diff @@
## main #4886 +/- ##
==========================================
- Coverage 90.97% 89.49% -1.48%
==========================================
Files 225 225
Lines 44244 50237 +5993
==========================================
+ Hits 40252 44961 +4709
- Misses 3992 5276 +1284
Continue to review full report at Codecov.
|
Get rid of `GETSTRUCT` to fill the form data and use `heap_deform_tuple` instead. This is necessary specially when you have variable lenght fields and/or fields that accept NULL values. This refactoring will be specially usefull in a following PR for Nested Continuous Aggregates where we'll add a new metadata to the catalog that can accept NULL values. Also refactor the rename view and schema code paths improving the readability and maintainability.
fabriziomello
force-pushed
the
refactor_continuous_agg_catalog_code
branch
from
b9d4825
to
4b3fdea
Compare
svenklemm
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of
GETSTRUCTto fill the form data and useheap_deform_tupleinstead. This is necessary specially when you have variable lenght fields and/or fields that accept NULL values. This refactoring will be specially usefull in a following PR for Nested Continuous Aggregates where we'll add a new metadata to the catalog that can accept NULL values.Also refactor the rename view and schema code paths improving the readability and maintainability.