Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dist_query dist_partial_agg on PG 15 #4964

Merged
merged 1 commit into from Nov 21, 2022
Merged

Conversation

sb230132
Copy link
Contributor

@sb230132 sb230132 commented Nov 11, 2022

Fix dist_query dist_partial_agg on PG 15

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #4964 (a43c9c5) into main (3b5653e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4964      +/-   ##
==========================================
- Coverage   89.59%   89.58%   -0.01%     
==========================================
  Files         226      226              
  Lines       51226    51225       -1     
==========================================
- Hits        45895    45889       -6     
- Misses       5331     5336       +5     
Impacted Files Coverage Δ
src/loader/bgw_message_queue.c 86.36% <0.00%> (-2.28%) ⬇️
src/bgw/scheduler.c 83.63% <0.00%> (-0.26%) ⬇️
tsl/src/bgw_policy/job.c 88.31% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5653e...a43c9c5. Read the comment docs.

@sb230132 sb230132 force-pushed the pg15_1 branch 5 times, most recently from 75d8192 to 152864e Compare November 18, 2022 06:08
@sb230132 sb230132 force-pushed the pg15_1 branch 2 times, most recently from f6b05ea to 3fd3199 Compare November 18, 2022 09:51
@sb230132 sb230132 changed the title Check PG 15.1 version Test PG 15 Nov 18, 2022
@sb230132 sb230132 marked this pull request as ready for review November 21, 2022 08:02
@sb230132 sb230132 changed the title Test PG 15 Fix dist_query dist_partial_agg on PG 15 Nov 21, 2022
@sb230132 sb230132 self-assigned this Nov 21, 2022
@sb230132 sb230132 requested a review from akuzm November 21, 2022 08:04
Copy link
Contributor

@lkshminarayanan lkshminarayanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions but LGTM.

  1. Can we remove the generic dist_partial_agg.out and dist_query.out now that we have version specific output files?
  2. A new result fields seems to have been added in 15.0 query plan output. Should we refer that change in the commit message?

@sb230132
Copy link
Contributor Author

Couple of questions but LGTM.

  1. Can we remove the generic dist_partial_agg.out and dist_query.out now that we have version specific output files?
  2. A new result fields seems to have been added in 15.0 query plan output. Should we refer that change in the commit message?

Yes, stale .out files have been removed.
New "Result" node which is specific to PG15 is tracked as part of #4928

@sb230132 sb230132 merged commit 89cede8 into timescale:main Nov 21, 2022
@sb230132 sb230132 deleted the pg15_1 branch November 21, 2022 10:40
@sb230132 sb230132 mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants