Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packaged postgres for sqlsmith and coverity CI #5021

Merged
merged 1 commit into from Nov 25, 2022

Conversation

svenklemm
Copy link
Member

The sqlsmith and coverity workflows used the cache postgres build but could not produce a build by themselves and therefore relied on other workflows to produce the cached binaries. This patch changes those workflows to use normal postgres packages instead of custom built postgres to remove that dependency.

@svenklemm svenklemm marked this pull request as ready for review November 25, 2022 07:31
@svenklemm svenklemm added this to the TimescaleDB 2.9 milestone Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #5021 (5155f03) into main (3b5653e) will increase coverage by 0.04%.
The diff coverage is 88.13%.

❗ Current head 5155f03 differs from pull request most recent head 82624e7. Consider uploading reports for the commit 82624e7 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5021      +/-   ##
==========================================
+ Coverage   89.59%   89.64%   +0.04%     
==========================================
  Files         226      227       +1     
  Lines       51226    51536     +310     
==========================================
+ Hits        45895    46198     +303     
- Misses       5331     5338       +7     
Impacted Files Coverage Δ
src/chunk.h 100.00% <ø> (ø)
tsl/src/chunk_api.c 95.67% <ø> (ø)
tsl/src/init.c 96.00% <ø> (ø)
src/cross_module_fn.c 67.55% <25.00%> (-0.93%) ⬇️
src/process_utility.c 90.19% <60.00%> (-0.08%) ⬇️
tsl/src/nodes/frozen_chunk_dml/frozen_chunk_dml.c 64.44% <64.44%> (ø)
tsl/src/fdw/modify_exec.c 85.22% <82.45%> (+0.25%) ⬆️
tsl/src/fdw/modify_plan.c 91.25% <83.33%> (-0.75%) ⬇️
tsl/src/chunk.c 94.39% <94.16%> (+0.78%) ⬆️
src/ts_catalog/chunk_data_node.c 98.89% <95.45%> (-0.48%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b94b99...82624e7. Read the comment docs.

@@ -25,35 +15,20 @@ jobs:
strategy:
fail-fast: false
matrix:
pg: ${{ fromJson(needs.config.outputs.pg_latest) }}
pg: [12,13,14]
os: [ubuntu-20.04]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we switch to 22.04 while we're at it?

@svenklemm svenklemm force-pushed the ci_pg_package branch 7 times, most recently from ab21d43 to 5155f03 Compare November 25, 2022 19:52
The sqlsmith and coverity workflows used the cache postgres build
but could not produce a build by themselves and therefore relied
on other workflows to produce the cached binaries. This patch
changes those workflows to use normal postgres packages instead
of custom built postgres to remove that dependency.
@svenklemm svenklemm enabled auto-merge (rebase) November 25, 2022 20:16
@svenklemm svenklemm merged commit 83b13cf into timescale:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants