Fix postgres server restart on background worker exit #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just testing |
Codecov Report
@@ Coverage Diff @@
## main #5117 +/- ##
==========================================
- Coverage 89.45% 89.45% -0.01%
==========================================
Files 227 227
Lines 51618 51614 -4
==========================================
- Hits 46174 46170 -4
Misses 5444 5444
Continue to review full report at Codecov.
|
svenklemm
reviewed
Dec 22, 2022
| @@ -1163,7 +1140,7 @@ ts_bgw_job_entrypoint(PG_FUNCTION_ARGS) | |||
| * not respect critical sections. We install an silent signal handler for | |||
| * invisible jobs, which will then die without printing an error message. | |||
| */ | |||
| pqsignal(SIGTERM, params.croak_silently ? croak : die); | |||
| pqsignal(SIGTERM, die); | |||
There was a problem hiding this comment.
Should remove reference to other function in comment above.
svenklemm
approved these changes
Dec 22, 2022
fabriziomello
approved these changes
Dec 22, 2022
konskov
force-pushed
the
croak_test
branch
2 times, most recently
from
8a96f40
to
a46e7b4
Compare
konskov
changed the title
Fixed by removing the croak signal handler that was introduced to enable the silent exit of the telemetry job.
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Dec 23, 2022
This release contains bug fixes since the 2.9.0 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * timescale#5072 Fix CAgg on CAgg bucket size validation * timescale#5101 Fix enabling compression on caggs with renamed columns * timescale#5106 Fix building against PG15 on Windows * timescale#5117 Fix postgres server restart on background worker exit * timescale#5121 Fix privileges for job_errors in update script
Merged
svenklemm
added a commit
that referenced
this pull request
Dec 23, 2022
This release contains bug fixes since the 2.9.0 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #5072 Fix CAgg on CAgg bucket size validation * #5101 Fix enabling compression on caggs with renamed columns * #5106 Fix building against PG15 on Windows * #5117 Fix postgres server restart on background worker exit * #5121 Fix privileges for job_errors in update script
svenklemm
added a commit
that referenced
this pull request
Dec 23, 2022
This release contains bug fixes since the 2.9.0 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #5072 Fix CAgg on CAgg bucket size validation * #5101 Fix enabling compression on caggs with renamed columns * #5106 Fix building against PG15 on Windows * #5117 Fix postgres server restart on background worker exit * #5121 Fix privileges for job_errors in update script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.