Add build matrix to Windows and Linux builds #5182
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5182 +/- ##
==========================================
- Coverage 89.41% 89.38% -0.03%
==========================================
Files 225 225
Lines 51693 51692 -1
==========================================
- Hits 46221 46206 -15
- Misses 5472 5486 +14
Continue to review full report at Codecov.
|
|
@erimatnor, @mahipv: please review this pull request.
|
mkindahl
force-pushed
the
fixing-workflow
branch
from
568220d
to
c5a5ee1
Compare
Build matrix is missing from the ignore workflows for the Windows and Linux builds, so this commit adds them.
mkindahl
force-pushed
the
fixing-workflow
branch
from
c5a5ee1
to
29a9292
Compare
| pg: [ 12, 13, 14, 15 ] | ||
| os: [ windows-2022 ] | ||
| build_type: ${{ fromJson(needs.config.outputs.build_type) }} | ||
| ignores: ["chunk_adaptive metadata"] |
There was a problem hiding this comment.
Do we need the parameters that don't influence the check name?
There was a problem hiding this comment.
Since we don't really build, I'd think these parameters don't influence anything and can be removed.
There was a problem hiding this comment.
It seems we need them for generating the names. The documentation at Handling skipped but required checks is not very clear, but if you look at #5176 that contains only documentation changes you can see that some jobs are stalling because the names do not match. They seem to match the parameters we have above.
It might be possible to remove some parameters: I just copied them from the other file because it is easier to ensure that the same matrix is created if you just cut and paste the code.
There was a problem hiding this comment.
I'm pushing it in the current state: it will be easier to see what can be removed or improved if it is in the main branch.
Build matrix is missing from the ignore workflows for the Windows and Linux builds, so this commit adds them.