Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer used compression code #5183

Merged
merged 1 commit into from Jan 16, 2023

Conversation

svenklemm
Copy link
Member

The recent refactoring of INSERT into compression chunk made this code obsolete but forgot to remove it in that patch.

@github-actions
Copy link

@fabriziomello, @pmwkaa: please review this pull request.

Powered by pull-review

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #5183 (3da7fd1) into main (73df496) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5183      +/-   ##
==========================================
+ Coverage   89.28%   89.39%   +0.11%     
==========================================
  Files         225      225              
  Lines       51779    51691      -88     
==========================================
- Hits        46230    46211      -19     
+ Misses       5549     5480      -69     
Impacted Files Coverage Δ
src/cross_module_fn.c 67.55% <ø> (ø)
tsl/src/compression/compression.c 95.57% <ø> (+8.70%) ⬆️
tsl/src/compression/compression.h 0.00% <ø> (ø)
tsl/src/init.c 96.00% <ø> (ø)
src/bgw/scheduler.c 83.88% <0.00%> (-3.84%) ⬇️
src/loader/bgw_launcher.c 89.51% <0.00%> (-2.55%) ⬇️
src/loader/bgw_message_queue.c 88.63% <0.00%> (-0.57%) ⬇️
src/bgw/job.c 93.24% <0.00%> (-0.17%) ⬇️
tsl/src/bgw_policy/job.c 87.28% <0.00%> (-0.05%) ⬇️
src/bgw/job_stat.c 92.18% <0.00%> (+0.31%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73df496...3da7fd1. Read the comment docs.

The recent refactoring of INSERT into compression chunk made this
code obsolete but forgot to remove it in that patch.
@svenklemm svenklemm enabled auto-merge (rebase) January 16, 2023 13:02
@svenklemm svenklemm merged commit dbe8964 into timescale:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants