Mark cagg_watermark parallel safe #5240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5240 +/- ##
===========================================
+ Coverage 63.10% 89.00% +25.89%
===========================================
Files 225 225
Lines 45666 51821 +6155
===========================================
+ Hits 28818 46123 +17305
+ Misses 16848 5698 -11150
Continue to review full report at Codecov.
|
fabriziomello
force-pushed
the
mark_cagg_watermark_parallel_safe
branch
4 times, most recently
from
a9e56d7
to
fc8c12f
Compare
fabriziomello
added
continuous_aggregate
enhancement
|
@lkshminarayanan, @akuzm: please review this pull request.
|
akuzm
reviewed
Jan 31, 2023
akuzm
reviewed
Jan 31, 2023
akuzm
approved these changes
Jan 31, 2023
mkindahl
reviewed
Jan 31, 2023
The `cagg_watermark` function perform just read-only operations so is safe to make it parallel safe to take advantage of the Postgres parallel query. Since 2.7 when we introduced the new Continuous Aggregate format we don't use partials anymore and those aggregate functions `partialize_agg` and `finalize_agg` are not parallel safe, so make no sense don't take advantage of Postgres parallel query for realtime Continuous Aggregates.
fabriziomello
force-pushed
the
mark_cagg_watermark_parallel_safe
branch
from
fc8c12f
to
6543fae
Compare
mkindahl
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cagg_watermarkfunction perform just read-only operations so issafe to make it parallel safe to take advantage of the Postgres
parallel query.
Since 2.7 when we introduced the new Continuous Aggregate format we
don't use partials anymore and those aggregate functions
partialize_aggandfinalize_aggare not parallel safe, so make nosense don't take advantage of Postgres parallel query for realtime
Continuous Aggregates.
Disable-Check: force-changelog-changed
Related to #4699