Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compression_hypertable ordering reliance #5292

Merged

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Feb 7, 2023

The hypertable_compression test had on implicit reliance on the ordering of tuples when querying the materialized results. This patch makes the ordering explicit in this test.

Disable-check: force-changelog-changed

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

@lkshminarayanan, @shhnwz: please review this pull request.

Powered by pull-review

@svenklemm svenklemm force-pushed the compression_hypertable_ordering branch from e47d6cb to 979665e Compare February 8, 2023 11:18
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #5292 (64d55e2) into main (caf79e0) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5292      +/-   ##
==========================================
- Coverage   89.36%   89.32%   -0.04%     
==========================================
  Files         225      225              
  Lines       51936    51913      -23     
==========================================
- Hits        46413    46373      -40     
- Misses       5523     5540      +17     
Impacted Files Coverage Δ
src/loader/bgw_launcher.c 89.51% <0.00%> (-2.55%) ⬇️
src/bgw/scheduler.c 83.63% <0.00%> (-1.80%) ⬇️
tsl/src/reorder.c 85.49% <0.00%> (-0.22%) ⬇️
tsl/src/nodes/data_node_dispatch.c 93.03% <0.00%> (-0.22%) ⬇️
src/nodes/chunk_append/planner.c 93.08% <0.00%> (-0.22%) ⬇️
tsl/src/bgw_policy/job.c 87.45% <0.00%> (-0.05%) ⬇️
tsl/src/data_node.c 96.05% <0.00%> (-0.03%) ⬇️
src/planner/planner.c 95.89% <0.00%> (-0.02%) ⬇️
tsl/src/fdw/data_node_scan_plan.c 98.08% <0.00%> (-0.02%) ⬇️
src/planner/expand_hypertable.c 94.23% <0.00%> (-0.01%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf79e0...64d55e2. Read the comment docs.

The hypertable_compression test had on implicit reliance on the
ordering of tuples when querying the materialized results.
This patch makes the ordering explicit in this test.
@svenklemm svenklemm force-pushed the compression_hypertable_ordering branch from 979665e to 64d55e2 Compare February 8, 2023 21:07
@svenklemm svenklemm enabled auto-merge (rebase) February 9, 2023 14:08
@svenklemm svenklemm merged commit 756ef68 into timescale:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants