Disallow MergeAppend optimizations when there is an OSM chunk #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSM chunks have their own fdw_private which conflicts with checks in the MergeAppend code path causing segfaults. This commit fixes this by returning early when there is an OSM chunk in the MergeAppendPath.
|
@konskov, @erimatnor: please review this pull request.
|
svenklemm
approved these changes
Apr 3, 2023
gayyappan
approved these changes
Apr 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #5519 +/- ##
==========================================
- Coverage 90.89% 90.75% -0.15%
==========================================
Files 228 229 +1
Lines 46192 53700 +7508
==========================================
+ Hits 41987 48734 +6747
- Misses 4205 4966 +761
... and 205 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akuzm
added
the
force-auto-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSM chunks have their own
fdw_privatewhich conflicts with checks in theMergeAppendcode path causing segfaults. This PR fixes this by returning early when there is an OSM chunk in theMergeAppendPath.