Move aggregate support function into _timescaledb_functions #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabriziomello, @erimatnor: please review this pull request.
|
akuzm
approved these changes
Apr 6, 2023
fabriziomello
approved these changes
Apr 6, 2023
This patch moves the support functions for histogram, first and last into the _timescaledb_functions schema. Since we alter the schema of the existing functions in upgrade scripts and do not change the aggregates this should work completely transparently for any user objects using those aggregates.
svenklemm
force-pushed
the
_aggregate_support_schema
branch
from
9143d35
to
f06e2f9
Compare
Codecov Report
@@ Coverage Diff @@
## main #5528 +/- ##
==========================================
+ Coverage 90.45% 90.55% +0.09%
==========================================
Files 229 229
Lines 53854 47371 -6483
==========================================
- Hits 48716 42898 -5818
+ Misses 5138 4473 -665 see 204 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the support functions for histogram, first and last into the _timescaledb_functions schema. Since we alter the schema of the existing functions in upgrade scripts and do not change the aggregates this should work completely transparently for any user objects using those aggregates.
Disable-check: force-changelog-changed