Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed transparent decompress chunk #5546

Merged

Conversation

shhnwz
Copy link
Contributor

@shhnwz shhnwz commented Apr 12, 2023

Transparent decompress chunk was added into to ignore list due to the side effect of #5118. This issue is to fix the flaky nature of the test.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #5546 (0ef8e7a) into main (20db884) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5546      +/-   ##
==========================================
- Coverage   90.58%   90.41%   -0.17%     
==========================================
  Files         229      229              
  Lines       47474    53962    +6488     
==========================================
+ Hits        43004    48792    +5788     
- Misses       4470     5170     +700     

see 204 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shhnwz shhnwz force-pushed the 5479-remove-transparent-decompress-chunk branch 6 times, most recently from 211e6d0 to 040bc4a Compare April 17, 2023 08:36
@shhnwz shhnwz marked this pull request as ready for review April 18, 2023 06:00
@github-actions github-actions bot requested a review from erimatnor April 18, 2023 06:01
@github-actions
Copy link

@erimatnor, @svenklemm: please review this pull request.

Powered by pull-review

@github-actions github-actions bot requested a review from svenklemm April 18, 2023 06:01
CHANGELOG.md Outdated
@@ -31,6 +31,7 @@ accidentally triggering the load of a previous DB version.**
* #5459 Fix issue creating dimensional constraints
* #5462 Fix segfault after column drop on compressed table
* #5470 Ensure superuser perms during copy/move chunk
* #5479 Fix flaky transparent_decompress_chunk test suite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont put test fixes in the changelog

Transparent decompress chunk was added into to ignore list due to
the side effect of timescale#5118. This issue is to fix the flaky nature of
the test.
@shhnwz shhnwz force-pushed the 5479-remove-transparent-decompress-chunk branch from 040bc4a to 0ef8e7a Compare April 18, 2023 06:31
@shhnwz shhnwz merged commit ca472eb into timescale:main Apr 18, 2023
38 of 41 checks passed
@shhnwz shhnwz deleted the 5479-remove-transparent-decompress-chunk branch April 18, 2023 08:43
@timescale-automation
Copy link

Automated backport to 2.10.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.10.x
You are currently cherry-picking commit ca472ebb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   tsl/test/shared/expected/transparent_decompress_chunk-12.out
	modified:   tsl/test/shared/sql/transparent_decompress_chunk.sql.in

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/gh_matrix_builder.py
	both modified:   tsl/test/shared/expected/transparent_decompress_chunk-13.out
	both modified:   tsl/test/shared/expected/transparent_decompress_chunk-14.out
	both modified:   tsl/test/shared/expected/transparent_decompress_chunk-15.out


Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Remove transparent_decompress_chunk-[12,13,14,15] from Ignore List.
4 participants