Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force dist_move_chunk as solo test for PG15.2 #5564

Merged
merged 1 commit into from Apr 14, 2023

Conversation

mahipv
Copy link
Contributor

@mahipv mahipv commented Apr 13, 2023

Running the test dist_move_chunk in parallel can
cause deadlock(and timeouts) in other tests running
in parallel on PG15.2. Force the test to run solo.

Disable-check: force-changelog-changed

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #5564 (73734cf) into main (ca240c3) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 73734cf differs from pull request most recent head c54040e. Consider uploading reports for the commit c54040e to get more accurate results

@@            Coverage Diff             @@
##             main    #5564      +/-   ##
==========================================
- Coverage   90.44%   90.38%   -0.06%     
==========================================
  Files         229      229              
  Lines       53938    53933       -5     
==========================================
- Hits        48785    48750      -35     
- Misses       5153     5183      +30     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mahipv mahipv changed the title Force dist_move as solo test for PG15.2 Force dist_move_chunk as solo test for PG15.2 Apr 13, 2023
Running the test dist_move_chunk in parallel can
cause a timeouts(deadlock) in other tests running
in parallel on PG15.2. Force the test to run solo.
@mahipv mahipv added the force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" label Apr 13, 2023
@mahipv
Copy link
Contributor Author

mahipv commented Apr 13, 2023

As seen in the runs of https://github.com/timescale/timescaledb/actions/runs/4687299189/jobs/8308210797,
the test dist_move_chunk runs in parallel causing the other tests in the group to fail.

@mahipv mahipv marked this pull request as ready for review April 13, 2023 16:55
@github-actions
Copy link

@svenklemm, @RafiaSabih: please review this pull request.

Powered by pull-review

@mahipv mahipv merged commit b136bb5 into timescale:main Apr 14, 2023
44 checks passed
@mahipv mahipv deleted the force_solo_test branch April 14, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-2.10.x force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants