Refactor compression code to reduce duplication #5593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
added
compression
tech-debt
antekresic
force-pushed
the
refactor-compress
branch
from
e011bc9
to
8fc65cd
Compare
Codecov Report
@@ Coverage Diff @@
## main #5593 +/- ##
==========================================
- Coverage 90.54% 90.41% -0.13%
==========================================
Files 229 229
Lines 47525 54023 +6498
==========================================
+ Hits 43031 48847 +5816
- Misses 4494 5176 +682
... and 203 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kgyrtkirk
approved these changes
Apr 20, 2023
| @@ -248,6 +248,8 @@ typedef struct RowCompressor | |||
| int64 num_compressed_rows; | |||
| /* if recompressing segmentwise, we must know this so we can reset the sequence number */ | |||
| bool segmentwise_recompress; | |||
| /* flag for checking if we are working on the first tuple */ | |||
| bool first_iteration; | |||
There was a problem hiding this comment.
this bool would not be needed in case row_compressor_new_row_is_in_new_group() could answer true on the first call
I had some not-so-nice ideas like:
- init segment_info with
is_nullbut with1value row_compressor->rows_compressed_into_current_valueis only0during the first invocation; after that we will always have an open row with>=1entries
I think they are not necessarily better - I'll just leave them here for a second consideration by you...
There was a problem hiding this comment.
Had some similar ideas but decided to go with this explicit way for a couple of reasons:
- matches the previous code more closely
- it makes a bit more understandable without possibility to introduce subtle bugs by relying on other fields
svenklemm
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable-check: force-changelog-changed