Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block unique idx creation on compressed hypertable #5594

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

antekresic
Copy link
Contributor

@antekresic antekresic commented Apr 20, 2023

This block was removed by accident, in order to support this we need to ensure the uniqueness in the compressed data which is something we should do in the future thus removing this block.

Fixes #5592

Disable-check: force-changelog-changed

This block was removed by accident, in order to support this we
need to ensure the uniqueness in the compressed data which is
something we should do in the future thus removing this block.
@github-actions
Copy link

@fabriziomello, @erimatnor: please review this pull request.

Powered by pull-review

Copy link
Member

@svenklemm svenklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could relax this when no compressed chunks are present, but doesnt make a big difference.

@antekresic
Copy link
Contributor Author

I've created a followup issue to remove this block:
#5595

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #5594 (23cb5cc) into main (a49fdbc) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5594      +/-   ##
==========================================
- Coverage   90.54%   90.50%   -0.04%     
==========================================
  Files         229      229              
  Lines       47525    47515      -10     
==========================================
- Hits        43031    43003      -28     
- Misses       4494     4512      +18     
Impacted Files Coverage Δ
src/process_utility.c 94.78% <100.00%> (+0.01%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@antekresic antekresic enabled auto-merge (rebase) April 20, 2023 14:00
@antekresic antekresic merged commit 23b3f8d into timescale:main Apr 20, 2023
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: UNIQUE INDEX creation on compressed chunks does not validate compressed data
3 participants