Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed transparent decompress chunk test which seem to be flaky. #5606

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

sb230132
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #5606 (1f20f23) into main (2f194e6) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5606      +/-   ##
==========================================
+ Coverage   90.36%   90.38%   +0.01%     
==========================================
  Files         229      229              
  Lines       54062    54057       -5     
==========================================
+ Hits        48851    48857       +6     
+ Misses       5211     5200      -11     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sb230132 sb230132 marked this pull request as ready for review April 24, 2023 10:31
@github-actions
Copy link

@RafiaSabih, @akuzm: please review this pull request.

Powered by pull-review

Copy link
Contributor

@shhnwz shhnwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1- You can remove "transparent_decompress_chunk-14" from the ignore list of gh_matrix_builder.py
2- Better to replace :PREFIX with :PREFIX_NO_ANALYZE for all JOIN queries.

@sb230132 sb230132 force-pushed the fix_test branch 2 times, most recently from 492a57a to adce6d7 Compare April 24, 2023 11:25
@sb230132
Copy link
Contributor Author

1- You can remove "transparent_decompress_chunk-14" from the ignore list of gh_matrix_builder.py 2- Better to replace :PREFIX with :PREFIX_NO_ANALYZE for all JOIN queries.

Fixed.

@sb230132 sb230132 merged commit 44dc042 into timescale:main Apr 24, 2023
39 of 41 checks passed
@sb230132 sb230132 deleted the fix_test branch April 25, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants