Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUC to enable/disable DML decompression #5653

Merged

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented May 3, 2023

Disable-check: force-changelog-changed

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #5653 (d619ee2) into main (6782beb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5653   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files         230      230           
  Lines       54468    54468           
=======================================
+ Hits        49557    49560    +3     
+ Misses       4911     4908    -3     
Impacted Files Coverage Δ
src/guc.c 95.45% <100.00%> (+0.06%) ⬆️
src/planner/planner.c 96.03% <100.00%> (ø)
tsl/src/compression/compression.c 95.87% <100.00%> (+0.01%) ⬆️
tsl/src/nodes/compress_dml/compress_dml.c 84.78% <100.00%> (ø)
tsl/src/planner.c 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fabriziomello fabriziomello marked this pull request as ready for review May 3, 2023 19:34
Copy link
Contributor

@sb230132 sb230132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for sharing the efforts.

src/guc.c Outdated Show resolved Hide resolved
tsl/test/expected/compression_conflicts.out Outdated Show resolved Hide resolved
src/nodes/hypertable_modify.c Outdated Show resolved Hide resolved
@fabriziomello fabriziomello force-pushed the ts_guc_enable_dml_decompression branch 2 times, most recently from b06c4de to ca6121d Compare May 4, 2023 13:07
@fabriziomello fabriziomello added this to the TimescaleDB 2.11 milestone May 4, 2023
@fabriziomello fabriziomello force-pushed the ts_guc_enable_dml_decompression branch from ca6121d to be71c18 Compare May 4, 2023 14:27
@fabriziomello fabriziomello enabled auto-merge (rebase) May 4, 2023 22:22
@fabriziomello fabriziomello force-pushed the ts_guc_enable_dml_decompression branch 2 times, most recently from f969911 to d11088a Compare May 5, 2023 13:14
@fabriziomello fabriziomello force-pushed the ts_guc_enable_dml_decompression branch 2 times, most recently from af32753 to 7748f3b Compare May 5, 2023 13:35
@fabriziomello fabriziomello force-pushed the ts_guc_enable_dml_decompression branch from 7748f3b to d619ee2 Compare May 5, 2023 14:22
@fabriziomello fabriziomello merged commit 3dc6824 into timescale:main May 5, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants