Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index scan handling in DML decompression #5657

Merged
merged 1 commit into from
May 5, 2023

Conversation

antekresic
Copy link
Contributor

@antekresic antekresic commented May 4, 2023

We need to use the correct qualifiers for index scans since the generic scan qualifiers are not populated in this case.

Fixes #5645

Disable-check: force-changelog-changed

@antekresic antekresic self-assigned this May 4, 2023
@antekresic antekresic marked this pull request as ready for review May 4, 2023 13:00
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #5657 (1536617) into main (8ca17e7) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5657      +/-   ##
==========================================
- Coverage   90.98%   90.94%   -0.04%     
==========================================
  Files         230      230              
  Lines       54457    54367      -90     
==========================================
- Hits        49545    49443     -102     
- Misses       4912     4924      +12     
Impacted Files Coverage Δ
tsl/src/compression/compression.c 95.85% <100.00%> (+0.03%) ⬆️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

We need to use the correct qualifiers for index scans since the
generic scan qualifiers are not populated in this case.
@antekresic antekresic merged commit 6782beb into timescale:main May 5, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build heap scan qualifiers from index scans during DML decompression in UPDATE/DELETE
3 participants