Remove FK from continuous_agg_migrate_plan

[fabriziomello]

During the cagg_migrate execution if the user set the drop_old parameter to true the routine will drop the old Continuous Aggregate leading to an inconsistent state because the catalog code don't handle this table as a normal catalog table so the records are not removed when dropping a Continuous Aggregate. The same problem will happen if you manually drop the old Continuous Aggregate after the migration.

Fixed it by removing the useless Foreign Key and also adding another column named user_view_definition to the main plan table just to store the original user view definition for troubleshooting purposes.

Disable-check: force-changelog-changed

Fixed #5662

[github-actions]

@lkshminarayanan, @sb230132: please review this pull request.

Powered by pull-review

[codecov]

Codecov Report

Merging #5664 (623d257) into main (8e69a99) will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5664      +/-   ##
==========================================
+ Coverage   90.97%   91.34%   +0.36%     
==========================================
  Files         230      228       -2     
  Lines       54473    51920    -2553     
==========================================
- Hits        49557    47424    -2133     
+ Misses       4916     4496     -420     

see 132 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[timescale-automation]

Automated backport to 2.10.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.10.x
You are currently cherry-picking commit f250eaa6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   sql/cagg_migrate.sql
	modified:   sql/pre_install/tables.sql
	modified:   tsl/test/expected/cagg_migrate.out
	modified:   tsl/test/expected/cagg_migrate_dist_ht.out
	modified:   tsl/test/sql/include/cagg_migrate_common.sql

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   sql/updates/latest-dev.sql
	both modified:   sql/updates/reverse-dev.sql

Job log