-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.11.0 #5684
Release 2.11.0 #5684
Conversation
@fabriziomello, @pmwkaa: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #5684 +/- ##
==========================================
- Coverage 87.71% 81.92% -5.80%
==========================================
Files 231 229 -2
Lines 54805 52162 -2643
Branches 12056 11376 -680
==========================================
- Hits 48072 42732 -5340
+ Misses 4925 4527 -398
- Partials 1808 4903 +3095 see 207 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -6,6 +6,15 @@ accidentally triggering the load of a previous DB version.** | |||
|
|||
## Unreleased | |||
|
|||
## 2.11.0 (2023-05-12) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we generally add this upgrade recommendation based on severity of the fixes, something like.
"This release contains bug fixes since the 2.10.3 release.
We recommend that you upgrade at the next available opportunity."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it also contains features; I've added:
This release contains new features and bug fixes since the 2.10.3 release.
We deem it moderate priority for upgrading.
1a0492b
to
4f6eb1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos.
Are we missing the SQL downgrade path? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed that you just moved the data from latest-dev to the upgrade file and made no changes, but it does not show up as a rename in GitHub. If you have made any changes, could you please mention what they were so that they can be reviewed?
its not a move because the file is recreated with empty content! it looks the same to me:
earlier changesets have also didn't listed is as a rename: 91b4a66 cd4509c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kgyrtkirk, I have added a few small changes to the changelog, mainly the noteworthy features section.
@gina-alioto @nenadmalic an optional request for you: do you mind also quickly checking the high level list with the noteworthy features in case my suggestions do not make? Thank you!
@@ -4,7 +4,17 @@ | |||
`psql` with the `-X` flag to prevent any `.psqlrc` commands from | |||
accidentally triggering the load of a previous DB version.** | |||
|
|||
## Unreleased | |||
## 2.11.0 (2023-05-12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update the date once we finalize the release date
@iroussos @gina-alioto @nenadmalic could you please take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kgyrtkirk, the latest version looks good to me!
No description provided.