Internal Server Error when loading Explorer tab #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
@nikkhils, @RafiaSabih: please review this pull request.
|
fabriziomello
requested changes
May 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #5723 +/- ##
==========================================
- Coverage 87.85% 87.79% -0.07%
==========================================
Files 234 234
Lines 54987 54982 -5
Branches 12114 12113 -1
==========================================
- Hits 48310 48269 -41
- Misses 4852 4855 +3
- Partials 1825 1858 +33 see 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sql/size_utils.sql
Outdated
| _timescaledb_catalog.hypertable ht | ||
| JOIN pg_class c ON relname = ht.table_name AND c.relkind = 'r' | ||
| JOIN pg_namespace n ON n.oid = c.relnamespace | ||
| AND n.nspname = schema_name_in |
There was a problem hiding this comment.
Suggested change
| AND n.nspname = schema_name_in | |
| AND n.nspname = ht.schema_name |
fabriziomello
approved these changes
May 31, 2023
This is with reference to a weird scenarios where chunk table entry exist in timescaledb catalog but it does not exist in PG catalog. The stale entry blocks executing hypertable_size function on the hypertable. The changes in this patch are related to improvements suggested for hypertable_size function which involves: 1. Locking the hypertable in ACCESS SHARE mode in function hypertable_size to avoid risk of chunks being dropped by another concurrent process. 2. Joining the hypertable and inherited chunk tables with "pg_class" to make sure that a stale table without an entry is pg_catalog is not included as part of hypertable size calculation. 3. An additional filter (schema_name) is required on pg_class to avoid calculating size of multiple hypertables with same in different schema. NOTE: With this change calling hypertable_size function will require select privilege on the table.
mahipv
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is with reference to a weird scenarios where chunk table entry exist in timescaledb catalog but it does not exist in PG catalog. The stale entry blocks executing hypertable_size function on the hypertable.
The changes in this patch are related to improvements suggested for hypertable_size function which involves:
NOTE: With this change calling hypertable_size function will require select privilege on the table.
Closes https://github.com/timescale/Support-Dev-Collab/issues/995
Disable-check: force-changelog-file