Ensure PR number is referenced in .unreleased files #5740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5740 +/- ##
==========================================
- Coverage 87.85% 87.79% -0.07%
==========================================
Files 234 234
Lines 54987 54982 -5
Branches 12114 12113 -1
==========================================
- Hits 48310 48271 -39
- Misses 4852 4856 +4
- Partials 1825 1855 +30 see 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kgyrtkirk
force-pushed
the
pr_num_check
branch
2 times, most recently
from
2a174e3
to
35edd35
Compare
|
@konskov, @gayyappan: please review this pull request.
|
konskov
approved these changes
Jun 2, 2023
Adds a simple check to ensure that the PR number is present at least once in the added changelog file. Also fixes an earlier PR which introduced a typo.
mahipv
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple check to ensure that the PR number is present at least once in the added changelog file.
Also fixes an earlier PR which introduced a typo.
Disable-check: force-changelog-file