Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG16: Remove recursion-marker values in enum AlterTableType #5889

Conversation

lkshminarayanan
Copy link
Contributor

@lkshminarayanan lkshminarayanan commented Jul 20, 2023

PG16 removed the recursion-marker values used to handle certain subcommands during an ALTER TABLE execution and provides an alternative flag. Removed the references to the recursion-marker values from timescaledb code.

postgres/postgres@840ff5f4

Disable-check: force-changelog-file

@lkshminarayanan lkshminarayanan added the pg16 Issue/PR related to support for PG16 label Jul 20, 2023
@lkshminarayanan lkshminarayanan marked this pull request as ready for review July 20, 2023 14:35
@github-actions
Copy link

@nikkhils, @RafiaSabih: please review this pull request.

Powered by pull-review

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5889 (2b7cc92) into main (b2773aa) will increase coverage by 7.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5889      +/-   ##
==========================================
+ Coverage   79.49%   87.04%   +7.54%     
==========================================
  Files         243      243              
  Lines       49131    55815    +6684     
  Branches    12318    12355      +37     
==========================================
+ Hits        39059    48583    +9524     
- Misses       4226     4893     +667     
+ Partials     5846     2339    -3507     
Files Changed Coverage Δ
src/process_utility.c 91.86% <ø> (+8.16%) ⬆️
tsl/src/process_utility.c 89.18% <ø> (+1.12%) ⬆️
tsl/src/remote/dist_ddl.c 92.02% <ø> (+5.26%) ⬆️

... and 220 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As long as you have checked that the earlier recurse based behavior still works with PG16, we are good I guess.

@lkshminarayanan lkshminarayanan enabled auto-merge (rebase) August 2, 2023 11:15
PG16 removed the recursion-marker values used to handle certain
subcommands during an ALTER TABLE execution and provides an alternative
flag. Removed the references to the recursion-marker values from
timescaledb code.

postgres/postgres@840ff5f4
@lkshminarayanan lkshminarayanan merged commit 52ed394 into timescale:main Aug 2, 2023
35 checks passed
@lkshminarayanan lkshminarayanan deleted the pg16-remove-recursion-markers branch August 2, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pg16 Issue/PR related to support for PG16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants