Backport two commits to 2.11.x #5940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when adding equivalence class members for the compressed chunk's variables, we would only consider Vars. This led us to ignore cases where the Var was wrapped in a RelabelType, returning inaccurate results. Fixed the issue by accepting Vars with RelabelType for segmentby equivalence class. Fixes timescale#5585 (cherry picked from commit 07433cc)
CMAKE_CPP_FLAGS is not a thing at all. Furthermore, CMAKE_CXX_FLAGS is not passed to a C compiler. pg_config uses CPPGLAGS for all includes, and needs to be passed into CMAKE_C_FLAGS as well. (cherry picked from commit 4273a27)
|
@svenklemm, @pmwkaa: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## 2.11.x #5940 +/- ##
=========================================
Coverage ? 91.36%
=========================================
Files ? 228
Lines ? 52131
Branches ? 0
=========================================
Hits ? 47631
Misses ? 4500
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
konskov
force-pushed
the
backport_2.11.x_noconflicts
branch
from
75c47c2
to
e8b6ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.