Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG16: Datum macros are now inline functions #5987

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

lkshminarayanan
Copy link
Contributor

@lkshminarayanan lkshminarayanan commented Aug 18, 2023

PG16 converted the GetDatum() and DatumGet() macros to inline functions. This doesn't affect most of our code but a few places like struct object initialisations cannot use inline functions. This commit updates all the places affected by this change.

postgres/postgres@c8b2ef05

Disable-check: force-changelog-file

@lkshminarayanan lkshminarayanan added the pg16 Issue/PR related to support for PG16 label Aug 18, 2023
@lkshminarayanan lkshminarayanan self-assigned this Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #5987 (a8cf64f) into main (09dd20d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5987      +/-   ##
==========================================
- Coverage   87.00%   86.95%   -0.05%     
==========================================
  Files         243      243              
  Lines       56006    55960      -46     
  Branches    12403    12384      -19     
==========================================
- Hits        48727    48661      -66     
- Misses       4937     4950      +13     
- Partials     2342     2349       +7     
Files Changed Coverage Δ
src/compression_with_clause.c 82.08% <ø> (ø)
src/process_utility.c 91.87% <ø> (ø)
src/ts_catalog/continuous_agg.c 93.94% <ø> (ø)
tsl/test/src/test_compression.c 79.19% <100.00%> (ø)

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lkshminarayanan lkshminarayanan marked this pull request as ready for review August 21, 2023 04:50
@github-actions
Copy link

@svenklemm, @nikkhils: please review this pull request.

Powered by pull-review

PG16 converted the *GetDatum() and DatumGet*() macros to inline
functions. This doesn't affect most of our code but a few places like
struct object initialisations cannot use inline functions. This commit
updates all the places affected by this change.

postgres/postgres@c8b2ef05
Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkshminarayanan lkshminarayanan enabled auto-merge (rebase) August 24, 2023 13:53
@lkshminarayanan lkshminarayanan merged commit 040d455 into timescale:main Aug 24, 2023
35 checks passed
@lkshminarayanan lkshminarayanan deleted the pg16-datum-macros branch August 24, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pg16 Issue/PR related to support for PG16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants