Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG16: Prohibit use of multi-node #6190

Merged

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Oct 12, 2023

Since multi-node is not supported on PG16, add errors to multi-node functions when run on this PostgreSQL version.

Disable-check: force-changelog-file

@fabriziomello fabriziomello added multinode pg16 Issue/PR related to support for PG16 labels Oct 12, 2023
@fabriziomello fabriziomello self-assigned this Oct 12, 2023
@fabriziomello fabriziomello force-pushed the pg16-remove-support-for-multinode branch 2 times, most recently from ec5effa to a437ddd Compare October 12, 2023 18:46
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #6190 (22dd9cc) into main (8f3bb0b) will decrease coverage by 16.44%.
The diff coverage is 0.00%.

❗ Current head 22dd9cc differs from pull request most recent head 9d680ef. Consider uploading reports for the commit 9d680ef to get more accurate results

@@             Coverage Diff             @@
##             main    #6190       +/-   ##
===========================================
- Coverage   81.47%   65.03%   -16.44%     
===========================================
  Files         246      246               
  Lines       56985    56949       -36     
  Branches    12629    12620        -9     
===========================================
- Hits        46426    37038     -9388     
- Misses       8176    18038     +9862     
+ Partials     2383     1873      -510     
Files Coverage Δ
tsl/src/remote/dist_commands.c 0.00% <ø> (-58.40%) ⬇️
tsl/test/src/remote/remote_exec.c 0.00% <ø> (-56.40%) ⬇️
src/hypertable.c 76.40% <0.00%> (-10.72%) ⬇️
tsl/src/dist_backup.c 0.00% <0.00%> (ø)
tsl/src/data_node.c 2.33% <0.00%> (-88.27%) ⬇️

... and 91 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fabriziomello fabriziomello force-pushed the pg16-remove-support-for-multinode branch from a437ddd to 52a0e99 Compare October 12, 2023 19:49
@fabriziomello fabriziomello marked this pull request as ready for review October 12, 2023 19:50
@github-actions
Copy link

@mkindahl, @antekresic: please review this pull request.

Powered by pull-review

@maxhertrampf
Copy link

Since multi-node has being deprecated

Sorry, what now? TimescaleDB is dropping multi node support? Is there any more info on that? 😮

src/hypertable.c Outdated Show resolved Hide resolved
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we should not remove features in minor releases and this is effectively an API-breaking change. We should deprecate the feature and the actual removal (and API-breaking change) is sometimes in the future.

src/hypertable.c Outdated Show resolved Hide resolved
tsl/src/data_node.c Outdated Show resolved Hide resolved
@erimatnor erimatnor changed the title PG16: Remove support of Multi-Node Prohibit use of multi-node on PG16 Oct 13, 2023
@erimatnor
Copy link
Contributor

Since multi-node has being deprecated

Sorry, what now? TimescaleDB is dropping multi node support? Is there any more info on that? 😮

To speed up the release of support for PG16, we are not going to support multi-node when run on PG16.

@fabriziomello fabriziomello force-pushed the pg16-remove-support-for-multinode branch 5 times, most recently from 4b28cc0 to b9b6434 Compare October 13, 2023 17:23
@fabriziomello fabriziomello force-pushed the pg16-remove-support-for-multinode branch 3 times, most recently from 27ba58a to 909aead Compare October 13, 2023 17:36
@fabriziomello fabriziomello force-pushed the pg16-remove-support-for-multinode branch 3 times, most recently from 18a5eb3 to 28cc4de Compare October 16, 2023 13:37
@fabriziomello fabriziomello changed the title Prohibit use of multi-node on PG16 PG16: Prohibit use of multi-node Oct 16, 2023
src/hypertable.c Outdated Show resolved Hide resolved
@fabriziomello fabriziomello force-pushed the pg16-remove-support-for-multinode branch 8 times, most recently from 275128c to 22dd9cc Compare October 18, 2023 13:31
Since multi-node is not supported on PG16, add errors to multi-node
functions when run on this PostgreSQL version.
@fabriziomello fabriziomello force-pushed the pg16-remove-support-for-multinode branch from 22dd9cc to 9d680ef Compare October 18, 2023 14:05
@fabriziomello fabriziomello merged commit a409065 into timescale:main Oct 18, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multinode pg16 Issue/PR related to support for PG16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants