Fix flaky SQL test #6445
Merged
Fix flaky SQL test #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
force-pushed
the
fix-bgw-launcher
branch
from
c188d91
to
2fbcc28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6445 +/- ##
==========================================
- Coverage 87.32% 87.31% -0.02%
==========================================
Files 185 185
Lines 41744 41698 -46
Branches 9283 9263 -20
==========================================
- Hits 36453 36407 -46
+ Misses 3614 3605 -9
- Partials 1677 1686 +9 ☔ View full report in Codecov by Sentry. |
antekresic
force-pushed
the
fix-bgw-launcher
branch
2 times, most recently
from
221db45
to
99a309e
Compare
|
@fabriziomello, @konskov: please review this pull request.
|
antekresic
force-pushed
the
fix-bgw-launcher
branch
from
99a309e
to
cdfc1d9
Compare
svenklemm
approved these changes
Dec 19, 2023
konskov
approved these changes
Dec 19, 2023
akuzm
reviewed
Dec 19, 2023
During dropping of the database used in the various tests we can encounter an error if something is still connected to the database, making the output unpredicatable. This change should reduce the possibility of that happening.
antekresic
force-pushed
the
fix-bgw-launcher
branch
from
cdfc1d9
to
174b0e4
Compare
akuzm
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During dropping of the database used in the various tests we can encounter an error if something is still connected to the database, making the output unpredicatable. This change should reduce the possibility of that happening.
Disable-check: force-changelog-file