Fix pg_dump flakiness #6447
Merged
Fix pg_dump flakiness #6447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During pg_dump creation of extra database, we terminate all processes connected to the template database but we don't revoke connection to it. This is why we still see random failures to create the new database.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6447 +/- ##
==========================================
- Coverage 87.32% 87.28% -0.05%
==========================================
Files 185 185
Lines 41744 41698 -46
Branches 9283 9263 -20
==========================================
- Hits 36452 36395 -57
- Misses 3613 3618 +5
- Partials 1679 1685 +6 ☔ View full report in Codecov by Sentry. |
svenklemm
approved these changes
Dec 20, 2023
akuzm
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During pg_dump creation of extra database, we terminate all processes connected to the template database but we don't revoke connection to it. This is why we still see random failures to create the new database.
Disable-check: force-changelog-file