Properly detect key columns for unique expression indexes #6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antekresic, @fabriziomello: please review this pull request.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6456 +/- ##
==========================================
+ Coverage 87.30% 87.31% +0.01%
==========================================
Files 187 187
Lines 41852 41824 -28
Branches 9316 9300 -16
==========================================
- Hits 36538 36520 -18
+ Misses 3641 3625 -16
- Partials 1673 1679 +6 ☔ View full report in Codecov by Sentry. |
akuzm
approved these changes
Dec 21, 2023
antekresic
approved these changes
Dec 21, 2023
svenklemm
force-pushed
the
compression_unique_keys
branch
from
73077bd
to
6b43bec
Compare
Previously for insert on hypertables with unique expression indexes we used to decompress full chunk as we would do no batch filtering in the dml compression. This patch adds batch filtering for columns that are part of an unique expression index but not filtered by an expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously for insert on hypertables with unique expression indexes we used to decompress full chunk as we would do no batch filtering in the dml compression. This patch adds batch filtering for columns that are part of an unique expression index but not filtered by an expression.
Disable-check: force-changelog-file