Reduce transparent_decompress_chunk test flakiness #6518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
commented
Jan 12, 2024
| @@ -24,12 +22,12 @@ ALTER TABLE metrics DROP COLUMN filler_2; | |||
| INSERT INTO metrics(time,device_id,v0,v1,v2,v3) SELECT time, device_id, device_id-1, device_id + 2, device_id + 0.5, NULL FROM generate_series('2000-01-06 0:00:00+0'::timestamptz,'2000-01-12 23:55:00+0','2m') gtime(time), generate_series(1,5,1) gdevice(device_id); | |||
| ALTER TABLE metrics DROP COLUMN filler_3; | |||
| INSERT INTO metrics(time,device_id,v0,v1,v2,v3) SELECT time, device_id, device_id, device_id + 2, device_id + 0.5, NULL FROM generate_series('2000-01-13 0:00:00+0'::timestamptz,'2000-01-19 23:55:00+0','2m') gtime(time), generate_series(1,5,1) gdevice(device_id); | |||
| CREATE INDEX ON metrics(time DESC); | |||
There was a problem hiding this comment.
These are just to speed up shared setup.
One of the merge join queries is known to switch inner and outer join relations because the costs seem to be the same. Adding an additional filter on one of the relations should change the costs enough so they are not interchangeable.
antekresic
force-pushed
the
remove-transparent-flakiness
branch
from
18968aa
to
3975b69
Compare
|
@nikkhils, @erimatnor: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6518 +/- ##
==========================================
- Coverage 87.33% 87.32% -0.01%
==========================================
Files 187 187
Lines 41899 41853 -46
Branches 9335 9315 -20
==========================================
- Hits 36593 36549 -44
+ Misses 3635 3627 -8
- Partials 1671 1677 +6 ☔ View full report in Codecov by Sentry. |
svenklemm
approved these changes
Jan 12, 2024
akuzm
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the merge join queries is known to switch inner and outer join relations because the costs seem to be the same. Adding an additional filter on one of the relations should change the costs enough so they are not interchangeable.
Fixes #5424
Disable-check: force-changelog-file