Enable debug info about compression scan paths #6532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
approved these changes
Jan 16, 2024
We enabled scans using indexes for a chunk that is to be compressed. The theory was that avoding tuplesort will be a win if there's a matching index to the compression settings. However, a few customers have reported very slow compress timings with lots of disk usage. It's important to know which scan is being used for the compression in such cases to help debug the issue. There's an existing GUC parameter which was "DEBUG" only till now. Make it available in release builds as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6532 +/- ##
=======================================
Coverage 79.74% 79.74%
=======================================
Files 187 187
Lines 36709 36663 -46
Branches 9290 9273 -17
=======================================
- Hits 29273 29238 -35
Misses 3102 3102
+ Partials 4334 4323 -11 ☔ View full report in Codecov by Sentry. |
mkindahl
approved these changes
Jan 16, 2024
konskov
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enabled scans using indexes for a chunk that is to be compressed. The theory was that avoding tuplesort will be a win if there's a matching index to the compression settings. However, a few customers have reported very slow compress timings with lots of disk usage. It's important to know which scan is being used for the compression in such cases to help debug the issue. There's an existing GUC parameter which was "DEBUG" only till now. Make it available in release builds as well.
Disable-check: force-changelog-file