Reduce index lock in segmentwise recompression #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
force-pushed
the
reduce-recompression-lock
branch
from
d20d0ab
to
f4e0314
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6558 +/- ##
=======================================
Coverage 79.74% 79.75%
=======================================
Files 188 188
Lines 36734 36688 -46
Branches 9288 9271 -17
=======================================
- Hits 29294 29260 -34
- Misses 3106 3110 +4
+ Partials 4334 4318 -16 ☔ View full report in Codecov by Sentry. |
antekresic
force-pushed
the
reduce-recompression-lock
branch
from
f4e0314
to
14dd438
Compare
akuzm
approved these changes
Jan 22, 2024
fabriziomello
approved these changes
Jan 23, 2024
antekresic
force-pushed
the
reduce-recompression-lock
branch
from
14dd438
to
b62f4a4
Compare
Segmentwise recompression grabbed an AccessExclusiveLock on the compressed chunk index. This would block all read operations on the chunk which involved said index. Reducing the lock to ExclusiveLock would allow reads, removing blocks from other ongoing operations.
antekresic
force-pushed
the
reduce-recompression-lock
branch
from
b62f4a4
to
ed95212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segmentwise recompression grabbed an AccessExclusiveLock on the compressed chunk index. This would block all read operations on the chunk which involved said index. Reducing the lock to ExclusiveLock would allow reads, removing blocks from other ongoing operations.
Fixes #6523