Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverityscan logically dead code #6607

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Feb 5, 2024

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (cddb4e9) 79.82% compared to head (1b46bf9) 79.86%.
Report is 4 commits behind head on main.

Files Patch % Lines
tsl/src/nodes/decompress_chunk/compressed_batch.c 58.33% 1 Missing and 4 partials ⚠️
tsl/src/compression/api.c 88.46% 1 Missing and 2 partials ⚠️
src/chunk.c 33.33% 0 Missing and 2 partials ⚠️
tsl/src/bgw_policy/job.c 0.00% 0 Missing and 1 partial ⚠️
tsl/src/nodes/skip_scan/planner.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6607      +/-   ##
==========================================
+ Coverage   79.82%   79.86%   +0.04%     
==========================================
  Files         190      190              
  Lines       37285    37249      -36     
  Branches     9458     9444      -14     
==========================================
- Hits        29761    29749      -12     
+ Misses       3122     3113       -9     
+ Partials     4402     4387      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziomello fabriziomello marked this pull request as ready for review February 5, 2024 20:37
@fabriziomello fabriziomello added this to the TimescaleDB 2.14 milestone Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

@svenklemm, @antekresic: please review this pull request.

Powered by pull-review

@fabriziomello fabriziomello enabled auto-merge (rebase) February 5, 2024 21:15
Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabriziomello fabriziomello merged commit 9e797dc into timescale:main Feb 6, 2024
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants