Use compressed chunk tupdesc to check which metadata columns we have #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6663 +/- ##
==========================================
+ Coverage 80.06% 81.44% +1.37%
==========================================
Files 190 191 +1
Lines 37181 36421 -760
Branches 9450 9459 +9
==========================================
- Hits 29770 29662 -108
+ Misses 2997 2985 -12
+ Partials 4414 3774 -640 ☔ View full report in Codecov by Sentry. |
akuzm
force-pushed
the
metadata
branch
2 times, most recently
from
30879e8
to
35586ec
Compare
The compressed qual pushdown will look at presence of metadata columns in the compressed chunk, not at whether the uncompressed column is an orderby. This way, the decision on which columns have metadata is made only during the creation of compressed chunk. This doesn't introduce any behavior changes, just changes the decision about which columns have metadata to happen in a single place. This will simplify experimenting with configurable metadata columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compressed qual pushdown will look at presence of metadata columns in the compressed chunk, not at whether the uncompressed column is an orderby. This way, the decision on which columns have metadata is made only during the creation of compressed chunk.
Apply the same approach in row compressor as well.
This doesn't introduce any behavior changes, just changes the decision about which columns have metadata to happen in a single place. This will simplify experimenting with configurable metadata columns.
Disable-check: force-changelog-file