Remove stats update from incremental recompression #6763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compression size stats are formed during initial compression. At that time, we know what the uncompressed stats were before the operation and the compressed stats after. But during incremental recompression, we are not decompressing the whole chunk thus we cannot update those statistics. So far, we only updated compressed stats and the tuple count. This ends up making the compression ratio incorrect since we are not updating all the stats. Removing any updates during incremental recompression will at least keep the initial stats consistent which is better than partially updated stats.
antekresic
force-pushed
the
remove-stats-update-recompression
branch
from
c317ee2
to
b3c5f95
Compare
svenklemm
approved these changes
Mar 13, 2024
|
LGTM |
fabriziomello
approved these changes
Mar 13, 2024
iroussos
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compression size stats are formed during initial compression. At that time, we know what the uncompressed stats were before the operation and the compressed stats after. But during incremental recompression, we are not decompressing the whole chunk thus we cannot update those statistics. So far, we only updated compressed stats and the tuple count. This ends up making the compression ratio incorrect since we are not updating all the stats. Removing any updates during incremental recompression will at least keep the initial stats consistent which is better than partially updated stats.
Disable-check: force-changelog-file