Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in default segmentby calc. in compression #7074

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

nikkhils
Copy link
Contributor

There was a typo in the query used for the calculation of default segmentbys in the case of compression.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.74%. Comparing base (59f50f2) to head (6145b17).
Report is 231 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7074      +/-   ##
==========================================
+ Coverage   80.06%   81.74%   +1.68%     
==========================================
  Files         190      200      +10     
  Lines       37181    37350     +169     
  Branches     9450     9740     +290     
==========================================
+ Hits        29770    30533     +763     
+ Misses       2997     2893     -104     
+ Partials     4414     3924     -490     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

There was a typo in the query used for the calculation of default
segmentbys in the case of compression.
@nikkhils nikkhils merged commit 60c9f4d into timescale:main Jun 27, 2024
38 checks passed
@nikkhils nikkhils deleted the def_segmentbys branch June 27, 2024 12:20
@svenklemm svenklemm added the bug label Jul 1, 2024
@timescale-automation
Copy link

Automated backport to 2.15.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.15.x
You are currently cherry-picking commit 60c9f4d24.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .unreleased/fix_7074
	modified:   sql/compression_defaults.sql

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tsl/test/expected/compression_defaults.out
	both modified:   tsl/test/sql/compression_defaults.sql


Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Jul 2, 2024
@zlepper
Copy link

zlepper commented Jul 3, 2024

@nikkhils Is there any chance this can be backported into a 2.15.x release? It's currently causing us to have disabled compression on some tables in dev, which is kinda annoying, and having to wait for 2.16 at the end of July feels a bit long to remove that workaround :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants