Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Scanner to do scans on already open relations #2173

Closed
erimatnor opened this issue Jul 31, 2020 · 0 comments · Fixed by #4111
Closed

Allow Scanner to do scans on already open relations #2173

erimatnor opened this issue Jul 31, 2020 · 0 comments · Fixed by #4111
Assignees
@erimatnor
Labels
tech-debt Needs refactoring and improvement tasks related to the source code and its architecture.

Comments

@erimatnor
Copy link
Contributor

The Scanner currently opens a relation, starts a scan, ends the scan, and the closes the relation. This is convenient, but not very flexible.

Sometimes it make sense to keep an open relation and do multiple scans or operations on it before closing it. Therefore it would make sense to allow the scanner to work on already open relation, i.e., only do start and end scan, not open and close the relation.

This would allow code to keep relations open for multiple processing steps, and then only close when done with it.
@NunoFilipeSantos NunoFilipeSantos added tech-debt Needs refactoring and improvement tasks related to the source code and its architecture. and removed feature-enhancement labels Sep 27, 2021
@erimatnor erimatnor self-assigned this Feb 10, 2022
erimatnor added a commit to erimatnor/timescaledb that referenced this issue Feb 17, 2022
@erimatnor
Allow control of relation open/close in Scanner
9438f57 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
erimatnor added a commit to erimatnor/timescaledb that referenced this issue Feb 18, 2022
@erimatnor
Allow control of relation open/close in Scanner
702c8e9 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
@erimatnor erimatnor mentioned this issue Feb 18, 2022
Merged
erimatnor added a commit to erimatnor/timescaledb that referenced this issue Feb 18, 2022
@erimatnor
Allow control of relation open/close in Scanner
92f18cf 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
erimatnor added a commit to erimatnor/timescaledb that referenced this issue Feb 22, 2022
@erimatnor
Allow control of relation open/close in Scanner
7f09255 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
erimatnor added a commit to erimatnor/timescaledb that referenced this issue Feb 23, 2022
@erimatnor
Allow control of relation open/close in Scanner
5b49b8c 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
erimatnor added a commit to erimatnor/timescaledb that referenced this issue Feb 23, 2022
@erimatnor
Allow control of relation open/close in Scanner
d304b43 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
erimatnor added a commit to erimatnor/timescaledb that referenced this issue Feb 25, 2022
@erimatnor
Allow control of relation open/close in Scanner
392ce3e 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
erimatnor added a commit to erimatnor/timescaledb that referenced this issue Feb 25, 2022
@erimatnor
Allow control of relation open/close in Scanner
5c77d1e 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
erimatnor added a commit to erimatnor/timescaledb that referenced this issue Feb 25, 2022
@erimatnor
Allow control of relation open/close in Scanner
696d5d5 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
erimatnor added a commit to erimatnor/timescaledb that referenced this issue Feb 25, 2022
@erimatnor
Allow control of relation open/close in Scanner
96cac7b 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
erimatnor added a commit that referenced this issue Feb 28, 2022
@erimatnor
Allow control of relation open/close in Scanner
32c1e3a 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes #2173
RafiaSabih pushed a commit to RafiaSabih/timescaledb that referenced this issue Apr 7, 2022
@erimatnor @RafiaSabih
Allow control of relation open/close in Scanner
b19de2b 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
RafiaSabih pushed a commit to RafiaSabih/timescaledb that referenced this issue Apr 8, 2022
@erimatnor @RafiaSabih
Allow control of relation open/close in Scanner
7b77904 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes timescale#2173
svenklemm pushed a commit that referenced this issue Apr 11, 2022
@erimatnor @svenklemm
Allow control of relation open/close in Scanner
65c8d34 
Make the Scanner module more flexible by allowing optional control
over when the scanned relation is opened and closed. Relations can
then remain open over multiple scans, which can improve performance
and efficiency.

Closes #2173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erimatnor erimatnor

Labels
tech-debt Needs refactoring and improvement tasks related to the source code and its architecture.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve chunk scan performance erimatnor/timescaledb
2 participants
@erimatnor @NunoFilipeSantos