Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Add license information on the extension description #5436

Closed
iroussos opened this issue Mar 14, 2023 · 1 comment · Fixed by #5440
Closed

[Enhancement]: Add license information on the extension description #5436

iroussos opened this issue Mar 14, 2023 · 1 comment · Fixed by #5440
Assignees
@konskov
Labels
enhancement An enhancement to an existing feature for functionality Team: Core Database

Comments

@iroussos
Copy link

iroussos commented Mar 14, 2023 •
edited

What type of enhancement is this?

User experience

What subsystems and features will be improved?

Other

What does the enhancement do?

We continue to see confusion in the market because some cloud providers are running the TimescaleDB Apache 2 Edition, but not making that clear.

At the moment it is not easy to find that information through standard commands. We'd like to provide that information when users run \dx, by chaning the “extension description” and including the TimescaleDB edition that is running.

Implementation proposal

Let's update the description of the extension when \dx runs (check that there is no limit for the description and if there is, that we are under it):

tsdb=> \dx
                     List of installed extensions
    Name    | Version | Schema |              Description
---------------------+---------+------------+-------------------------------------------------------------------
 pg_stat_statements | 1.9  | public  | track execution statistics of all SQL statements executed
 plpgsql      | 1.0  | pg_catalog | PL/pgSQL procedural language

- timescaledb    | 2.9.3 | public  | Enables scalable inserts and complex queries for time-series data 
+ timescaledb    | 2.9.3 | public  | (Community Edition) Enables scalable inserts and complex queries for time-series data  
+ or
+ timescaledb    | 2.9.3 | public  | (Apache 2 Edition) Enables scalable inserts and complex queries for time-series data  

 timescaledb_toolkit | 1.13.1 | public  | timescaledb_toolkit
 tsm_system_rows  | 1.0  | public  | TABLESAMPLE method which accepts number of rows as a limit

Optional (open question for the implementation): Is it possible to include the license in the name of the extension instead of the description?

Not sure if the name is used for lookups, etc so it would break internal stuff or integrations if we were to change it. But if we could, it would look even better.

- timescaledb    | 2.9.3 | public  | Enables scalable inserts and complex queries for time-series data 
+ timescaledb (Community Edition)  | 2.9.3 | public  | Enables scalable inserts and complex queries for time-series data  
+ or
+ timescaledb (Apache 2 Edition) | 2.9.3 | public  | Enables scalable inserts and complex queries for time-series data
@iroussos iroussos added enhancement An enhancement to an existing feature for functionality Team: Core Database labels Mar 14, 2023
@iroussos
Copy link
Author

FYI @jfjoly - do you mind doing a quick check of the proposed way to present the edition?

@iroussos iroussos mentioned this issue Mar 14, 2023
Closed
@konskov konskov self-assigned this Mar 14, 2023
@konskov konskov mentioned this issue Mar 14, 2023
Merged
konskov added a commit to konskov/timescaledb that referenced this issue Mar 14, 2023
@konskov
Add license information to extension description
8c20d08 
Fixes timescale#5436
konskov added a commit to konskov/timescaledb that referenced this issue Mar 14, 2023
@konskov
Add license information to extension description
3f663e4 
Fixes timescale#5436
konskov added a commit to konskov/timescaledb that referenced this issue Mar 17, 2023
@konskov
Add license information to extension description
32f07d0 
Fixes timescale#5436
konskov added a commit to konskov/timescaledb that referenced this issue Mar 17, 2023
@konskov
Add license information to extension description
3a4a5df 
Fixes timescale#5436
konskov added a commit to konskov/timescaledb that referenced this issue Mar 17, 2023
@konskov
Add license information to extension description
a43d6e4 
Fixes timescale#5436
konskov added a commit to konskov/timescaledb that referenced this issue Mar 17, 2023
@konskov
Add license information to extension description
b8a7830 
Fixes timescale#5436
konskov added a commit to konskov/timescaledb that referenced this issue Mar 17, 2023
@konskov
Add license information to extension description
b6356fb 
Fixes timescale#5436
konskov added a commit to konskov/timescaledb that referenced this issue Mar 17, 2023
@konskov
Add license information to extension description
42d84be 
Fixes timescale#5436
konskov added a commit to konskov/timescaledb that referenced this issue Mar 20, 2023
@konskov
Add license information to extension description
53e9c41 
Fixes timescale#5436
konskov added a commit to konskov/timescaledb that referenced this issue Mar 20, 2023
@konskov
Add license information to extension description
b7f2366 
Fixes timescale#5436
fabriziomello pushed a commit that referenced this issue Mar 20, 2023
@konskov @fabriziomello
Add license information to extension description
8cccc37 
Fixes #5436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konskov konskov

Labels
enhancement An enhancement to an existing feature for functionality Team: Core Database
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add license information to extension description konskov/timescaledb
2 participants
@iroussos @konskov