Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New invalidations CI script? #331

Closed
ChrisRackauckas opened this issue Jan 3, 2023 · 2 comments
Closed

New invalidations CI script? #331

ChrisRackauckas opened this issue Jan 3, 2023 · 2 comments

Comments

@ChrisRackauckas
Copy link
Contributor

https://github.com/SciML/LinearSolve.jl/blob/main/.github/workflows/Invalidations.yml is what we have right now.

Is there a better script or some improvements we should be making?

@timholy
Copy link
Owner

timholy commented Jan 11, 2023

Since that just largely triggers the action, I think that's OK? But see julia-actions/julia-invalidations#10

@ChrisRackauckas
Copy link
Contributor Author

My best guess is that this is instead intended to count the number of invalidations caused by methods in the package? In which case something like

That's what I meant, the thing seems to give a lot of false alarms so your improvements there are probably necessary. It would be nice to if it also just signaled if invalidations went up, i.e. was a regression test, rather than 0 invalidations which 🤷 always fails right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants