fix broken logdet tests

JuliaLinearAlgebra · May 10, 2020 · 87a89f9 · 87a89f9
1 parent 65d41d2
commit 87a89f9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -2,5 +2,11 @@ using WoodburyMatrices
 using LinearAlgebra, SparseArrays, Test
 using Random: seed!
 
+# helper function for testing logdet
+function randpsd(sidelength)
+    Q = randn(sidelength, sidelength)
+    return Q * Q'
+end
+
 include("woodbury.jl")
 include("symwoodbury.jl")
diff --git a/test/symwoodbury.jl b/test/symwoodbury.jl
@@ -205,8 +205,7 @@ str = String(take!(iob))
 
 # logdet
 # make sure all matrices are PSD because I don't want complex numbers
-randpsd(S) = randn(S, S) |> Q -> Q * Q'
-W = SymWoodbury([randpsd(10) for _ in 1:3]...)
+W = SymWoodbury([randpsd(50) for _ in 1:3]...)
 @test logdet(W) ≈ log(det(W)) ≈ logdet(Array(W))
 @test all(logabsdet(W) .≈ logabsdet(Array(W)))
 

diff --git a/test/woodbury.jl b/test/woodbury.jl
@@ -164,8 +164,7 @@ end
 
 # logdet
 # make sure all matrices are PSD because I don't want complex numbers
-randpsd(S) = randn(S, S) |> Q -> Q * Q'
-W = Woodbury([randpsd(10) for _ in 1:4]...)
+W = Woodbury([randpsd(50) for _ in 1:4]...)
 @test logdet(W) ≈ log(det(W)) ≈ logdet(Array(W))
 @test all(logabsdet(W) .≈ logabsdet(Array(W)))