Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream #32

Closed
dhirschfeld opened this issue Jan 11, 2019 · 4 comments
Closed

Upstream #32

dhirschfeld opened this issue Jan 11, 2019 · 4 comments

Comments

@dhirschfeld
Copy link

Looks like @ian-r-rose is implementing this upstream:
jupyterlab/jupyterlab#5855

@ian-r-rose
Copy link

Don't mean to step on your toes @timkpaine, and what I have done is definitely less featureful than your extension here. My primary goal is to get a reasonable live-editing of local HTML documents. I'd love to hear your thoughts on the PR against core JupyterLab.

@timkpaine
Copy link
Owner

I'm working on proxying #31

I don't have any interest in a html viewer, only the ability to view other sites. Ideally this will allow http over https and vice versa. So i think for now this is more of a replacement for jupyterlab_html not this package.

@dhirschfeld
Copy link
Author

I just opened this issue as a user of Tim's extension. Thanks for chiming in - it helps me know whether or not I still need to install this extension as well as the upstream version...

@ian-r-rose
Copy link

My PR has some overlap with this extension, but I've been waffling about whether to keep it there. The iframe-ing will certainly work better with a proxy like the one here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants